Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 94833002: Remove usage of deprecated V8 APIs from bindings code generator (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
Reviewers:
Mike West
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove usage of deprecated V8 APIs from bindings code generator BUG=324225 R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -278 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 17 chunks +27 lines, -27 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObjectInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp View 12 chunks +24 lines, -24 lines 0 comments Download
M Source/bindings/tests/results/V8TestConditionalInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestConstants.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomVisitDOMWrapperInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomWrapInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestDependentLifetimeInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestEvent.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestExtendedEvent.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 3 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 6 chunks +40 lines, -40 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 5 chunks +58 lines, -58 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years ago (2013-11-28 12:18:46 UTC) #1
Mike West
On 2013/11/28 12:18:46, jochen wrote: Awesome. LGTM.
7 years ago (2013-11-28 12:19:44 UTC) #2
jochen (gone - plz use gerrit)
7 years ago (2013-11-28 12:22:08 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r162830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698