Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: Source/bindings/tests/results/V8TestCallback.cpp

Issue 94833002: Remove usage of deprecated V8 APIs from bindings code generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 return true; 216 return true;
217 217
218 v8::Context::Scope scope(v8Context); 218 v8::Context::Scope scope(v8Context);
219 v8::Handle<v8::Value> thisHandle = thisValue.v8Value(); 219 v8::Handle<v8::Value> thisHandle = thisValue.v8Value();
220 if (thisHandle.IsEmpty()) { 220 if (thisHandle.IsEmpty()) {
221 if (!isScriptControllerTerminating()) 221 if (!isScriptControllerTerminating())
222 CRASH(); 222 CRASH();
223 return true; 223 return true;
224 } 224 }
225 ASSERT(thisHandle->IsObject()); 225 ASSERT(thisHandle->IsObject());
226 v8::Handle<v8::Value> argHandle = v8::Integer::New(arg, isolate); 226 v8::Handle<v8::Value> argHandle = v8::Integer::New(isolate, arg);
227 if (argHandle.IsEmpty()) { 227 if (argHandle.IsEmpty()) {
228 if (!isScriptControllerTerminating()) 228 if (!isScriptControllerTerminating())
229 CRASH(); 229 CRASH();
230 return true; 230 return true;
231 } 231 }
232 v8::Handle<v8::Value> argv[] = { argHandle }; 232 v8::Handle<v8::Value> argv[] = { argHandle };
233 233
234 bool callbackReturnValue = false; 234 bool callbackReturnValue = false;
235 return !invokeCallback(m_callback.newLocal(isolate), v8::Handle<v8::Object>: :Cast(thisHandle), 1, argv, callbackReturnValue, executionContext(), isolate); 235 return !invokeCallback(m_callback.newLocal(isolate), v8::Handle<v8::Object>: :Cast(thisHandle), 1, argv, callbackReturnValue, executionContext(), isolate);
236 } 236 }
237 237
238 } // namespace WebCore 238 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698