Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp

Issue 94833002: Remove usage of deprecated V8 APIs from bindings code generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp b/Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp
index 1112719f1bd625d3f3bc79313bd70d22361131b4..b5db376157918b23fe15dc2d6b00dcdbb3b88bca 100644
--- a/Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp
+++ b/Source/bindings/tests/results/V8TestDoNotCheckConstantsInterface.cpp
@@ -95,7 +95,7 @@ static v8::Handle<v8::FunctionTemplate> ConfigureV8TestDoNotCheckConstantsInterf
V8DOMConfiguration::installConstants(functionTemplate, prototypeTemplate, V8TestDoNotCheckConstantsInterfaceConstants, WTF_ARRAY_LENGTH(V8TestDoNotCheckConstantsInterfaceConstants), isolate);
// Custom toString template
- functionTemplate->Set(v8::String::NewSymbol("toString"), V8PerIsolateData::current()->toStringTemplate());
+ functionTemplate->Set(v8::String::NewFromUtf8(isolate, "toString", v8::String::kInternalizedString), V8PerIsolateData::current()->toStringTemplate());
return functionTemplate;
}
@@ -107,11 +107,11 @@ v8::Handle<v8::FunctionTemplate> V8TestDoNotCheckConstantsInterface::GetTemplate
return result->value.newLocal(isolate);
TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "BuildDOMTemplate");
- v8::HandleScope handleScope(isolate);
- v8::Handle<v8::FunctionTemplate> templ =
+ v8::EscapableHandleScope handleScope(isolate);
+ v8::Local<v8::FunctionTemplate> templ =
ConfigureV8TestDoNotCheckConstantsInterfaceTemplate(data->rawTemplate(&wrapperTypeInfo, currentWorldType), isolate, currentWorldType);
data->templateMap(currentWorldType).add(&wrapperTypeInfo, UnsafePersistent<v8::FunctionTemplate>(isolate, templ));
- return handleScope.Close(templ);
+ return handleScope.Escape(templ);
}
bool V8TestDoNotCheckConstantsInterface::hasInstance(v8::Handle<v8::Value> jsValue, v8::Isolate* isolate, WrapperWorldType currentWorldType)
« no previous file with comments | « Source/bindings/tests/results/V8TestDependentLifetimeInterface.cpp ('k') | Source/bindings/tests/results/V8TestEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698