Source/bindings/tests/results/V8TestCallback.cpp - Issue 94833002: Remove usage of deprecated V8 APIs from bindings code generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestCallback.cpp

Issue 94833002: Remove usage of deprecated V8 APIs from bindings code generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestCallback.cpp

diff --git a/Source/bindings/tests/results/V8TestCallback.cpp b/Source/bindings/tests/results/V8TestCallback.cpp

index 2d0716d48d471c06b6e5427b042c743c31abfb7b..92710ac9a1b3ff9f23f208482bd26339c0b6fc44 100644

--- a/Source/bindings/tests/results/V8TestCallback.cpp

+++ b/Source/bindings/tests/results/V8TestCallback.cpp

@@ -223,7 +223,7 @@ bool V8TestCallback::callbackWithThisArg(ScriptValue thisValue, int arg)

return true;

}

ASSERT(thisHandle->IsObject());

- v8::Handle<v8::Value> argHandle = v8::Integer::New(arg, isolate);

+ v8::Handle<v8::Value> argHandle = v8::Integer::New(isolate, arg);

if (argHandle.IsEmpty()) {

if (!isScriptControllerTerminating())

CRASH();