Issue 945273002: Fixes bad code in OnViewVisibilityChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945273002: Fixes bad code in OnViewVisibilityChanged (Closed)

Created:
5 years, 10 months ago by sky

Modified:
5 years, 10 months ago

Reviewers:
alhaad, Elliot Glaysher

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fixes bad code in OnViewVisibilityChanged Problem was when OnViewVisibilityChanged is received the client was calling back to the server to change the visibility again. This is totally wrong as the client receiving a notification doesn't need to tell the server to change the visibility agian. This lead to problems if a client was rapidly changing the visibility as the second client would receive the change and then try to change the visibility too. R=erg@chromium.org, alhaad@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3d23dae011859a2aae49f1d1adde705c8e85d819

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -8 lines)			Patch
M	mojo/services/view_manager/public/cpp/lib/view.cc	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/view_manager/public/cpp/lib/view_private.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/view_manager/public/cpp/view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	services/view_manager/view_manager_client_apptest.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

5 years, 10 months ago (2015-02-23 18:23:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d23dae011859a2aae49f1d1adde705c8e85d819 (presubmit successful).

Expand Messages | Collapse Messages