mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc - Issue 945273002: Fixes bad code in OnViewVisibilityChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

Issue 945273002: Fixes bad code in OnViewVisibilityChanged (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

diff --git a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

index b988903ac3fc814e24cf593dd69028f3590d1fd6..9a3c022d86a3a104b2d6ad42a0095a743d17a0bf 100644

--- a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

+++ b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc

@@ -379,7 +379,7 @@ void ViewManagerClientImpl::OnViewVisibilityChanged(Id view_id, bool visible) {

// Deal with this some how.

View* view = GetViewById(view_id);

if (view)

- view->SetVisible(visible);

+ ViewPrivate(view).LocalSetVisible(visible);

}

void ViewManagerClientImpl::OnViewDrawnStateChanged(Id view_id, bool drawn) {

« no previous file with comments | « mojo/services/view_manager/public/cpp/lib/view.cc ('k') | mojo/services/view_manager/public/cpp/lib/view_private.h » ('j') | no next file with comments »