Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: services/view_manager/view_manager_client_apptest.cc

Issue 945273002: Fixes bad code in OnViewVisibilityChanged (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/view_manager/public/cpp/view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/view_manager/view_manager_client_apptest.cc
diff --git a/services/view_manager/view_manager_client_apptest.cc b/services/view_manager/view_manager_client_apptest.cc
index 994bfb0a7edd73bef974641ffde03110341d66f8..52c2587d2541ec7a35e411d446a14ad957981b5f 100644
--- a/services/view_manager/view_manager_client_apptest.cc
+++ b/services/view_manager/view_manager_client_apptest.cc
@@ -425,10 +425,7 @@ class VisibilityChangeObserver : public ViewObserver {
} // namespace
-// TODO(alhaad): Re-enable this once
-// ViewManagerClientImpl::OnViewVisibilityChanged() does not cause a race
-// condition when called from two clients.
-TEST_F(ViewManagerTest, DISABLED_Visible) {
+TEST_F(ViewManagerTest, Visible) {
View* view1 = window_manager()->CreateView();
view1->SetVisible(true);
window_manager()->GetRoot()->AddChild(view1);
« no previous file with comments | « mojo/services/view_manager/public/cpp/view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698