Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Side by Side Diff: mojo/services/view_manager/public/cpp/view.h

Issue 945273002: Fixes bad code in OnViewVisibilityChanged (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SERVICES_VIEW_MANAGER_PUBLIC_CPP_VIEW_H_ 5 #ifndef MOJO_SERVICES_VIEW_MANAGER_PUBLIC_CPP_VIEW_H_
6 #define MOJO_SERVICES_VIEW_MANAGER_PUBLIC_CPP_VIEW_H_ 6 #define MOJO_SERVICES_VIEW_MANAGER_PUBLIC_CPP_VIEW_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 152
153 void LocalDestroy(); 153 void LocalDestroy();
154 void LocalAddChild(View* child); 154 void LocalAddChild(View* child);
155 void LocalRemoveChild(View* child); 155 void LocalRemoveChild(View* child);
156 // Returns true if the order actually changed. 156 // Returns true if the order actually changed.
157 bool LocalReorder(View* relative, OrderDirection direction); 157 bool LocalReorder(View* relative, OrderDirection direction);
158 void LocalSetBounds(const Rect& old_bounds, const Rect& new_bounds); 158 void LocalSetBounds(const Rect& old_bounds, const Rect& new_bounds);
159 void LocalSetViewportMetrics(const ViewportMetrics& old_metrics, 159 void LocalSetViewportMetrics(const ViewportMetrics& old_metrics,
160 const ViewportMetrics& new_metrics); 160 const ViewportMetrics& new_metrics);
161 void LocalSetDrawn(bool drawn); 161 void LocalSetDrawn(bool drawn);
162 void LocalSetVisible(bool visible);
162 163
163 // Methods implementing visibility change notifications. See ViewObserver 164 // Methods implementing visibility change notifications. See ViewObserver
164 // for more details. 165 // for more details.
165 void NotifyViewVisibilityChanged(View* target); 166 void NotifyViewVisibilityChanged(View* target);
166 // Notifies this view's observers. Returns false if |this| was deleted during 167 // Notifies this view's observers. Returns false if |this| was deleted during
167 // the call (by an observer), otherwise true. 168 // the call (by an observer), otherwise true.
168 bool NotifyViewVisibilityChangedAtReceiver(View* target); 169 bool NotifyViewVisibilityChangedAtReceiver(View* target);
169 // Notifies this view and its child hierarchy. Returns false if |this| was 170 // Notifies this view and its child hierarchy. Returns false if |this| was
170 // deleted during the call (by an observer), otherwise true. 171 // deleted during the call (by an observer), otherwise true.
171 bool NotifyViewVisibilityChangedDown(View* target); 172 bool NotifyViewVisibilityChangedDown(View* target);
(...skipping 28 matching lines...) Expand all
200 }; 201 };
201 202
202 std::map<const void*, Value> prop_map_; 203 std::map<const void*, Value> prop_map_;
203 204
204 MOJO_DISALLOW_COPY_AND_ASSIGN(View); 205 MOJO_DISALLOW_COPY_AND_ASSIGN(View);
205 }; 206 };
206 207
207 } // namespace mojo 208 } // namespace mojo
208 209
209 #endif // MOJO_SERVICES_VIEW_MANAGER_PUBLIC_CPP_VIEW_H_ 210 #endif // MOJO_SERVICES_VIEW_MANAGER_PUBLIC_CPP_VIEW_H_
OLDNEW
« no previous file with comments | « mojo/services/view_manager/public/cpp/lib/view_private.h ('k') | services/view_manager/view_manager_client_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698