Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 942963004: Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead. (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead. BUG= Committed: https://crrev.com/b5fc4b808c8570764554478f3459b23f91a631a7 Cr-Commit-Position: refs/heads/master@{#26874}

Patch Set 1 #

Patch Set 2 : Remove the distinction between named/indexed access checks, always pass "undefined" as "name" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -682 lines) Patch
M src/ic/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 4 chunks +27 lines, -83 lines 0 comments Download
M src/log.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/log.cc View 1 2 chunks +2 lines, -26 lines 0 comments Download
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 25 chunks +38 lines, -51 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 4 chunks +8 lines, -12 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 6 chunks +12 lines, -23 lines 0 comments Download
M test/cctest/test-api.cc View 1 39 chunks +79 lines, -461 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-25 21:49:27 UTC) #2
Toon Verwaest
Actually, I just realized that for v8::ACCESS_KEYS we were passing in undefined_value as the name. ...
5 years, 10 months ago (2015-02-25 21:52:15 UTC) #3
Toon Verwaest
Additionally, do we need to distinguish between named/index access at all?
5 years, 10 months ago (2015-02-25 21:52:46 UTC) #4
Toon Verwaest
Changed the CL to reflect this. From now we'll just always call the named callback ...
5 years, 10 months ago (2015-02-25 22:54:24 UTC) #5
dcarney
On 2015/02/25 22:54:24, Toon Verwaest wrote: > Changed the CL to reflect this. From now ...
5 years, 10 months ago (2015-02-26 08:08:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942963004/20001
5 years, 10 months ago (2015-02-26 10:13:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 10:34:50 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 10:35:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5fc4b808c8570764554478f3459b23f91a631a7
Cr-Commit-Position: refs/heads/master@{#26874}

Powered by Google App Engine
This is Rietveld 408576698