Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: src/lookup.cc

Issue 942963004: Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove the distinction between named/indexed access checks, always pass "undefined" as "name" Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/lookup-inl.h" 10 #include "src/lookup-inl.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 } 65 }
66 return Handle<JSObject>::cast(receiver_); 66 return Handle<JSObject>::cast(receiver_);
67 } 67 }
68 68
69 69
70 bool LookupIterator::IsBootstrapping() const { 70 bool LookupIterator::IsBootstrapping() const {
71 return isolate_->bootstrapper()->IsActive(); 71 return isolate_->bootstrapper()->IsActive();
72 } 72 }
73 73
74 74
75 bool LookupIterator::HasAccess(v8::AccessType access_type) const { 75 bool LookupIterator::HasAccess() const {
76 DCHECK_EQ(ACCESS_CHECK, state_); 76 DCHECK_EQ(ACCESS_CHECK, state_);
77 return isolate_->MayNamedAccess(GetHolder<JSObject>(), name_, access_type); 77 return isolate_->MayAccess(GetHolder<JSObject>());
78 } 78 }
79 79
80 80
81 void LookupIterator::ReloadPropertyInformation() { 81 void LookupIterator::ReloadPropertyInformation() {
82 state_ = BEFORE_PROPERTY; 82 state_ = BEFORE_PROPERTY;
83 state_ = LookupInHolder(*holder_map_, *holder_); 83 state_ = LookupInHolder(*holder_map_, *holder_);
84 DCHECK(IsFound() || holder_map_->is_dictionary_map()); 84 DCHECK(IsFound() || holder_map_->is_dictionary_map());
85 } 85 }
86 86
87 87
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 } 353 }
354 return false; 354 return false;
355 } 355 }
356 356
357 357
358 void LookupIterator::InternalizeName() { 358 void LookupIterator::InternalizeName() {
359 if (name_->IsUniqueName()) return; 359 if (name_->IsUniqueName()) return;
360 name_ = factory()->InternalizeString(Handle<String>::cast(name_)); 360 name_ = factory()->InternalizeString(Handle<String>::cast(name_));
361 } 361 }
362 } } // namespace v8::internal 362 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698