src/lookup.cc - Issue 942963004: Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 942963004: Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove the distinction between named/indexed access checks, always pass "undefined" as "name" Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index 672c026c3c7fdc3c30abe9674b940a630d8852e0..b629f1980cac6c080c323766167295b46efe55f1 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -72,9 +72,9 @@ bool LookupIterator::IsBootstrapping() const {

}

-bool LookupIterator::HasAccess(v8::AccessType access_type) const {

+bool LookupIterator::HasAccess() const {

DCHECK_EQ(ACCESS_CHECK, state_);

- return isolate_->MayNamedAccess(GetHolder<JSObject>(), name_, access_type);

+ return isolate_->MayAccess(GetHolder<JSObject>());

}

« no previous file with comments | « src/lookup.h ('k') | src/objects.cc » ('j') | no next file with comments »