Remove internal use of v8::AccessType, always pass v8::ACCESS_HAS instead.

test/cctest/test-api-interceptors.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "test/cctest/test-api.h"
 
 #include "include/v8-util.h"
 #include "src/api.h"
@@ skipping 2916 matching lines @@
       Object::Cast(*data)->GetAlignedPointerFromInternalField(0));
 }
 
 
 struct AccessCheckData {
   int count;
   bool result;
 };
 
 
-bool SimpleNamedAccessChecker(Local<v8::Object> global, Local<Value> name,
-                              v8::AccessType type, Local<Value> data) {
+bool SimpleAccessChecker(Local<v8::Object> global, Local<Value> name,
+                         v8::AccessType type, Local<Value> data) {
   auto access_check_data = GetWrappedObject<AccessCheckData>(data);
   access_check_data->count++;
   return access_check_data->result;
-}
-
-
-bool SimpleIndexedAccessChecker(Local<v8::Object> global, uint32_t index,
-                                v8::AccessType type, Local<Value> data) {
-  auto access_check_data = GetWrappedObject<AccessCheckData>(data);
-  access_check_data->count++;
-  return access_check_data->result;
 }
 
 
 struct ShouldInterceptData {
   int value;
   bool should_intercept;
 };
 
 
 void ShouldNamedInterceptor(Local<Name> name,
@@ skipping 48 matching lines @@
   {
     v8::NamedPropertyHandlerConfiguration conf(ShouldNamedInterceptor);
     conf.flags = v8::PropertyHandlerFlags::kAllCanRead;
     conf.data =
         BuildWrappedObject<ShouldInterceptData>(isolate, &intercept_data_1);
     intercepted_1->SetHandler(conf);
   }
 
   auto checked = v8::ObjectTemplate::New(isolate);
   checked->SetAccessCheckCallbacks(
-      SimpleNamedAccessChecker, nullptr,
+      SimpleAccessChecker, nullptr,
       BuildWrappedObject<AccessCheckData>(isolate, &access_check_data), false);
 
   context->Global()->Set(v8_str("intercepted_0"), intercepted_0->NewInstance());
   context->Global()->Set(v8_str("intercepted_1"), intercepted_1->NewInstance());
   auto checked_instance = checked->NewInstance();
   checked_instance->Set(v8_str("whatever"), v8_num(17));
   context->Global()->Set(v8_str("checked"), checked_instance);
   CompileRun(
       "checked.__proto__ = intercepted_1;"
       "intercepted_1.__proto__ = intercepted_0;");
@@ skipping 45 matching lines @@
   {
     v8::IndexedPropertyHandlerConfiguration conf(ShouldIndexedInterceptor);
     conf.flags = v8::PropertyHandlerFlags::kAllCanRead;
     conf.data =
         BuildWrappedObject<ShouldInterceptData>(isolate, &intercept_data_1);
     intercepted_1->SetHandler(conf);
   }
 
   auto checked = v8::ObjectTemplate::New(isolate);
   checked->SetAccessCheckCallbacks(
-      nullptr, SimpleIndexedAccessChecker,
+      SimpleAccessChecker, nullptr,
       BuildWrappedObject<AccessCheckData>(isolate, &access_check_data), false);
 
   context->Global()->Set(v8_str("intercepted_0"), intercepted_0->NewInstance());
   context->Global()->Set(v8_str("intercepted_1"), intercepted_1->NewInstance());
   auto checked_instance = checked->NewInstance();
   context->Global()->Set(v8_str("checked"), checked_instance);
   checked_instance->Set(15, v8_num(17));
   CompileRun(
       "checked.__proto__ = intercepted_1;"
       "intercepted_1.__proto__ = intercepted_0;");
 
   checked_instance->TurnOnAccessCheck();
   CHECK_EQ(0, access_check_data.count);
 
   access_check_data.result = true;
   ExpectInt32("checked[15]", 17);
   CHECK_EQ(1, access_check_data.count);
 
   access_check_data.result = false;
   ExpectInt32("checked[15]", intercept_data_0.value);
   CHECK_EQ(2, access_check_data.count);
 
   intercept_data_1.should_intercept = true;
   ExpectInt32("checked[15]", intercept_data_1.value);
   CHECK_EQ(3, access_check_data.count);
 }