Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 940083002: Make SkPixelRef::isLocked() debug-only, remove related dead code. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkPixelRef::isLocked() debug-only, remove related dead code. DM's okay locally with no diffs, no failures. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8e65712486c66108677a9b0a55ad3e7ca94db555 Committed: https://skia.googlesource.com/skia/+/96d68b704626fe3543ea14a48b4f909519644b54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -89 lines) Patch
M include/core/SkPixelRef.h View 3 chunks +1 line, -41 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 3 chunks +8 lines, -39 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 6 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
mtklein_C
5 years, 10 months ago (2015-02-19 16:42:51 UTC) #2
reed1
lgtm
5 years, 10 months ago (2015-02-19 20:21:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940083002/1
5 years, 10 months ago (2015-02-19 20:32:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/8e65712486c66108677a9b0a55ad3e7ca94db555
5 years, 10 months ago (2015-02-20 02:50:03 UTC) #6
reed2
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/940323003/ by reed@chromium.org. ...
5 years, 10 months ago (2015-02-20 03:58:59 UTC) #7
mtklein
On 2015/02/20 03:58:59, reed2 wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 10 months ago (2015-02-20 04:00:18 UTC) #8
mtklein
On 2015/02/20 04:00:18, mtklein wrote: > On 2015/02/20 03:58:59, reed2 wrote: > > A revert ...
5 years, 10 months ago (2015-02-20 17:33:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940083002/1
5 years, 10 months ago (2015-02-20 17:34:10 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:40:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/96d68b704626fe3543ea14a48b4f909519644b54

Powered by Google App Engine
This is Rietveld 408576698