Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree This method is only called in CueTimeline::removeCue, and in there it's only used to reset the m_notifyRegion flag in VTTCue temporarily while calling removeDisplayTree. Remove notifyRegionWhenRemovingDisplayTree in favor of passing a flag to removeDisplayTree. In order to achieve this though we need to hoist the submerged call to removeDisplayTree from TextTrackCue::setIsActive. This in turn makes it clear that removeDisplayTree was called twice in the relevant context. BUG=321654, 322434 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190547

Patch Set 1 #

Patch Set 2 : Hoist removeDisplayTree-call from setIsActive. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -33 lines) Patch
M Source/core/html/track/CueTimeline.cpp View 1 2 chunks +9 lines, -10 lines 0 comments Download
M Source/core/html/track/TextTrackCue.h View 1 1 chunk +7 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/html/track/TextTrackCueList.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 10 months ago (2015-02-20 10:17:44 UTC) #2
philipj_slow
lgtm Less member state yay
5 years, 10 months ago (2015-02-20 10:41:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939193002/20001
5 years, 10 months ago (2015-02-20 10:44:07 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 10:47:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190547

Powered by Google App Engine
This is Rietveld 408576698