Source/core/html/track/TextTrackCueList.cpp - Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrackCueList.cpp

Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Hoist removeDisplayTree-call from setIsActive. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/TextTrackCueList.cpp

diff --git a/Source/core/html/track/TextTrackCueList.cpp b/Source/core/html/track/TextTrackCueList.cpp

index 2619d2ce532e897b358a2cb6343579cc0cb3400c..626182d4ca2a2c8ab7b431171a9feae7ad98cdf1 100644

--- a/Source/core/html/track/TextTrackCueList.cpp

+++ b/Source/core/html/track/TextTrackCueList.cpp

@@ -114,6 +114,8 @@ bool TextTrackCueList::remove(TextTrackCue* cue)

return false;

cue->setIsActive(false);

+ cue->removeDisplayTree();

m_list.remove(index);

return true;

}

« no previous file with comments | « Source/core/html/track/TextTrackCue.cpp ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | no next file with comments »