Source/core/html/track/vtt/VTTCue.h - Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTCue.h

Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Hoist removeDisplayTree-call from setIsActive. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/vtt/VTTCue.h

diff --git a/Source/core/html/track/vtt/VTTCue.h b/Source/core/html/track/vtt/VTTCue.h

index 92ca5ed08183a3a50d97d9c750fa7fa8bd01efe0..3159f1070a212e59acae6ce7d5b4be493504de3a 100644

--- a/Source/core/html/track/vtt/VTTCue.h

+++ b/Source/core/html/track/vtt/VTTCue.h

@@ -111,8 +111,7 @@ public:

virtual void updateDisplay(HTMLDivElement& container) override;

virtual void updateDisplayTree(double movieTime) override;

- virtual void removeDisplayTree() override;

- virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) override;

+ virtual void removeDisplayTree(RemovalNotification) override;

void markFutureAndPastNodes(ContainerNode*, double previousTimestamp, double movieTime);

@@ -189,7 +188,6 @@ private:

bool m_snapToLines : 1;

bool m_displayTreeShouldChange : 1;

- bool m_notifyRegion : 1;

};

// VTTCue is currently the only TextTrackCue subclass.

« no previous file with comments | « Source/core/html/track/TextTrackCueList.cpp ('k') | Source/core/html/track/vtt/VTTCue.cpp » ('j') | no next file with comments »