Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/html/track/TextTrackCue.h

Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Hoist removeDisplayTree-call from setIsActive. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/track/CueTimeline.cpp ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 bool pauseOnExit() const { return m_pauseOnExit; } 70 bool pauseOnExit() const { return m_pauseOnExit; }
71 void setPauseOnExit(bool); 71 void setPauseOnExit(bool);
72 72
73 int cueIndex(); 73 int cueIndex();
74 void invalidateCueIndex(); 74 void invalidateCueIndex();
75 75
76 using EventTarget::dispatchEvent; 76 using EventTarget::dispatchEvent;
77 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override; 77 virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
78 78
79 bool isActive(); 79 bool isActive();
80 void setIsActive(bool); 80 void setIsActive(bool active) { m_isActive = active; }
81 81
82 virtual void updateDisplay(HTMLDivElement& container) = 0; 82 virtual void updateDisplay(HTMLDivElement& container) = 0;
83 83
84 // FIXME: Consider refactoring to eliminate or merge the following three mem bers. 84 // FIXME: Consider refactoring to eliminate or merge the following three mem bers.
85 // https://code.google.com/p/chromium/issues/detail?id=322434 85 // https://code.google.com/p/chromium/issues/detail?id=322434
86 virtual void updateDisplayTree(double movieTime) = 0; 86 virtual void updateDisplayTree(double movieTime) = 0;
87 virtual void removeDisplayTree() = 0; 87
88 virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) = 0; 88 enum RemovalNotification {
89 DontNotifyRegion,
90 NotifyRegion
91 };
92 virtual void removeDisplayTree(RemovalNotification = NotifyRegion) = 0;
89 93
90 virtual const AtomicString& interfaceName() const override; 94 virtual const AtomicString& interfaceName() const override;
91 95
92 #ifndef NDEBUG 96 #ifndef NDEBUG
93 virtual String toString() const = 0; 97 virtual String toString() const = 0;
94 #endif 98 #endif
95 99
96 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter); 100 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
97 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit); 101 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
98 102
(...skipping 13 matching lines...) Expand all
112 116
113 RawPtrWillBeMember<TextTrack> m_track; 117 RawPtrWillBeMember<TextTrack> m_track;
114 118
115 bool m_isActive : 1; 119 bool m_isActive : 1;
116 bool m_pauseOnExit : 1; 120 bool m_pauseOnExit : 1;
117 }; 121 };
118 122
119 } // namespace blink 123 } // namespace blink
120 124
121 #endif // TextTrackCue_h 125 #endif // TextTrackCue_h
OLDNEW
« no previous file with comments | « Source/core/html/track/CueTimeline.cpp ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698