Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939073002: [Files.app a11y] Add missing a11y labels into buttons (Closed)

Created:
5 years, 10 months ago by yoshiki
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app a11y] Add missing a11y labels into buttons BUG=459695 TEST=manually tested Committed: https://crrev.com/9477fcd74eb63e8becea7d763c9321e2fadcf106 Cr-Commit-Position: refs/heads/master@{#317049}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 1 chunk +6 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 10 months ago (2015-02-19 13:27:49 UTC) #2
fukino
lgtm. Thanks!
5 years, 10 months ago (2015-02-19 14:21:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939073002/20001
5 years, 10 months ago (2015-02-19 14:34:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 14:56:32 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 14:57:08 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9477fcd74eb63e8becea7d763c9321e2fadcf106
Cr-Commit-Position: refs/heads/master@{#317049}

Powered by Google App Engine
This is Rietveld 408576698