Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: ui/file_manager/file_manager/main.html

Issue 939073002: [Files.app a11y] Add missing a11y labels into buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/main.html
diff --git a/ui/file_manager/file_manager/main.html b/ui/file_manager/file_manager/main.html
index 176c8175e857a38b2005a60fdb30ab20ebf6c72a..2a45b35dc34b58e69d3770b2e4f876227df3c150 100644
--- a/ui/file_manager/file_manager/main.html
+++ b/ui/file_manager/file_manager/main.html
@@ -314,7 +314,8 @@
<div class="dialog-header">
<div id="location-breadcrumbs" class="breadcrumbs"></div>
<div id="cancel-selection-button-wrapper">
- <paper-button id="cancel-selection-button" tabindex="-1">
+ <paper-button id="cancel-selection-button" tabindex="-1"
+ i18n-values="aria-label:CANCEL_SELECTION_BUTTON_LABEL">
<span class="icon-arrow-back"></span>
<span i18n-content="CANCEL_SELECTION_BUTTON_LABEL"></span>
</paper-button>
@@ -322,15 +323,18 @@
<div id="files-selected-label"></div>
<div class="spacer"></div>
<button id="tasks" class="combobutton" menu="#tasks-menu"
- tabindex="7">
+ tabindex="7"
+ i18n-values="aria-label:TASKS_BUTTON_LABEL">
<paper-ripple fit></paper-ripple>
</button>
- <button id="search-button" class="icon-button" tabindex="8">
+ <button id="search-button" class="icon-button" tabindex="8"
+ i18n-values="aria-label:SEARCH_TEXT_LABEL">
<paper-ripple fit class="recenteringTouch circle"></paper-ripple>
</button>
<div id="search-box">
<paper-input-decorator i18n-values="label:SEARCH_TEXT_LABEL">
- <input is="core-input" type="search" tabindex="-1" i18n-values="aria-label:SEARCH_TEXT_LABEL">
+ <input is="core-input" type="search" tabindex="-1"
+ i18n-values="aria-label:SEARCH_TEXT_LABEL">
</paper-input-decorator>
<button class="clear" tabindex="-1"></button>
</div>
@@ -360,7 +364,8 @@
<core-icon icon="arrow-drop-down"></core-icon>
<paper-ripple fit class="recenteringTouch circle"></paper-ripple>
</button>
- <button id="view-button" class="icon-button" tabindex="13">
+ <button id="view-button" class="icon-button" tabindex="13"
+ i18n-values="aria-label:CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL">
<paper-ripple fit class="recenteringTouch circle"></paper-ripple>
</button>
<button id="gear-button" class="icon-button" tabindex="14" menu="#gear-menu"
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698