Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js

Issue 939073002: [Files.app a11y] Add missing a11y labels into buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
index 03e4fbd27d3d5af4e28a1624dabf42e44cdc3463..83464b92e9603aaa69088d88d03adf01e78ab7e4 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
@@ -369,8 +369,12 @@ FileManagerUI.prototype.relayout = function() {
FileManagerUI.prototype.setCurrentListType = function(listType) {
this.listContainer.setCurrentListType(listType);
- this.toggleViewButton.classList.toggle(
- 'thumbnail', listType === ListContainer.ListType.DETAIL);
+ var isListView = (listType === ListContainer.ListType.DETAIL);
+ this.toggleViewButton.classList.toggle('thumbnail', isListView);
+
+ var label = isListView ? str('CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL') :
+ str('CHANGE_TO_LISTVIEW_BUTTON_LABEL');
+ this.toggleViewButton.setAttribute('aria-label', label);
this.relayout();
};
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/ui/directory_tree.js ('k') | ui/file_manager/file_manager/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698