ui/file_manager/file_manager/foreground/js/ui/directory_tree.js - Issue 939073002: [Files.app a11y] Add missing a11y labels into buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Issue 939073002: [Files.app a11y] Add missing a11y labels into buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc ('k') | ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

index 724c1621077809e6066e0e481a1ddb4c94fbb00d..03a3e88d46debd1a78cba482c94b9348c300fcbb 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

@@ -535,6 +535,7 @@ VolumeItem.prototype.setupEjectButton_ = function(rowElement) {

ejectButton.addEventListener(

'mousedown', function(event) { event.stopPropagation() });

ejectButton.className = 'root-eject';

+ ejectButton.setAttribute('aria-label', str('UNMOUNT_DEVICE_BUTTON_LABEL'));

ejectButton.addEventListener('click', function(event) {

event.stopPropagation();

var unmountCommand = cr.doc.querySelector('command#unmount');