Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 937883003: Rename CancellableTaskFactory::task() for clarity. (Closed)

Created:
5 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, scheduler-bugs_chromium.org, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename CancellableTaskFactory::task() for clarity. Rename CancellableTaskFactory::task() to CancellableTaskFactory::createTaskAndCancelPrevious() making it clearer what it does. Must be submitted after: https://codereview.chromium.org/866273005/ BUG=428349 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195528

Patch Set 1 #

Patch Set 2 : Try to fix diffbase. #

Patch Set 3 : Changed tthe rename to cancelAndCreate #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M Source/core/dom/ScriptRunner.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLParserScheduler.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M Source/platform/scheduler/CancellableTaskFactory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scheduler/CancellableTaskFactory.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 1 2 11 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
alex clarke (OOO till 29th)
5 years, 10 months ago (2015-02-19 15:23:50 UTC) #2
Sami
Thanks for putting this together. This is clear but a little verbose. How does cancelAndCreate() ...
5 years, 10 months ago (2015-02-19 16:13:54 UTC) #4
rmcilroy
On 2015/02/19 16:13:54, Sami wrote: > Thanks for putting this together. This is clear but ...
5 years, 10 months ago (2015-02-19 16:17:07 UTC) #5
alex clarke (OOO till 29th)
On 2015/02/19 16:13:54, Sami wrote: > Thanks for putting this together. This is clear but ...
5 years, 10 months ago (2015-02-19 16:20:36 UTC) #6
alex clarke (OOO till 29th)
5 years, 10 months ago (2015-02-19 16:21:01 UTC) #7
Sami
Sweet, lgtm.
5 years, 10 months ago (2015-02-19 16:21:58 UTC) #8
alex clarke (OOO till 29th)
jochen@chromium.org: Could I get an OWNERS review please :)
5 years, 7 months ago (2015-05-19 10:08:14 UTC) #10
Sami
Non-owner lgtm.
5 years, 7 months ago (2015-05-19 10:13:40 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-19 11:30:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937883003/60001
5 years, 7 months ago (2015-05-19 11:32:06 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 12:47:20 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195528

Powered by Google App Engine
This is Rietveld 408576698