Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 9328: Initial (stub) port of jump targets to the ARM platform.... (Closed)

Created:
12 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Initial (stub) port of jump targets to the ARM platform. The JumpTarget and VirtualFrame classes have been split out into their own source files, with platform-specific include and implementation files. Much of the code can ultimately be shared. Committed: http://code.google.com/p/v8/source/detail?r=712

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1525 lines, -835 lines) Patch
M src/SConscript View 1 2 1 chunk +13 lines, -8 lines 0 comments Download
M src/ast.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/codegen-arm.h View 1 2 8 chunks +19 lines, -57 lines 0 comments Download
M src/codegen-arm.cc View 1 2 52 chunks +113 lines, -98 lines 0 comments Download
M src/codegen-ia32.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/jump-target.h View 1 chunk +37 lines, -0 lines 1 comment Download
A src/jump-target-arm.h View 1 chunk +184 lines, -0 lines 1 comment Download
A src/jump-target-arm.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A src/jump-target-ia32.h View 1 1 chunk +198 lines, -0 lines 0 comments Download
A src/jump-target-ia32.cc View 1 chunk +215 lines, -0 lines 0 comments Download
M src/macro-assembler-ia32.h View 1 2 2 chunks +0 lines, -412 lines 0 comments Download
M src/macro-assembler-ia32.cc View 1 2 1 chunk +0 lines, -260 lines 0 comments Download
A src/virtual-frame.h View 1 chunk +37 lines, -0 lines 0 comments Download
A src/virtual-frame-arm.h View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A src/virtual-frame-arm.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A src/virtual-frame-ia32.h View 1 2 1 chunk +176 lines, -0 lines 0 comments Download
A src/virtual-frame-ia32.cc View 1 chunk +120 lines, -0 lines 1 comment Download
A src/virtual-frame-ia32-inl.h View 1 chunk +147 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
This change is merely to get ARM to compile and work again after the changes ...
12 years, 1 month ago (2008-11-04 14:32:06 UTC) #1
Kevin Millikin (Chromium)
Erik, can you take a look at this? It's a port of IA32 code to ...
12 years, 1 month ago (2008-11-07 10:40:42 UTC) #2
Erik Corry
12 years, 1 month ago (2008-11-07 11:55:10 UTC) #3
LGTM

http://codereview.chromium.org/9328/diff/220/233
File src/jump-target-arm.h (right):

http://codereview.chromium.org/9328/diff/220/233#newcode35
Line 35: //
-------------------------------------------------------------------------
Almost everything in this file looks architecture independent - should be
factored out at some point.

http://codereview.chromium.org/9328/diff/220/232
File src/jump-target.h (right):

http://codereview.chromium.org/9328/diff/220/232#newcode31
Line 31: #if defined(ARM) || defined (__arm__) || defined(__thumb__)
This is kinda messy.  I don't have a better suggestion right now, but perhaps
the solution becomes obvious once the commonality is factored out of these two
include files.

http://codereview.chromium.org/9328/diff/220/226
File src/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/9328/diff/220/226#newcode46
Line 46: parameter_count_ = cgen->scope()->num_parameters();
I think you should be using the initalizer list syntax here.

Powered by Google App Engine
This is Rietveld 408576698