Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 929533002: [App banners] Add UMA metrics (Closed)

Created:
5 years, 10 months ago by gone
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@banner_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[App banners] Add UMA metrics DEPENDENT on 914813002 * Combines app_banner_metrics_ids.*, app_banner_utilities.*, and app_banner_metrics_id_list.* into the app_banner_metrics.* files. * Gets rid of the Java-side metrics because we can control and react to them entirely from native-side calls now. * Updates the histograms accordingly. BUG=457416 TBR=thakis Committed: https://crrev.com/aada8ca53d972120510a5c0de6484d029e004e93 Cr-Commit-Position: refs/heads/master@{#316936}

Patch Set 1 #

Patch Set 2 : Eliminating diff #

Patch Set 3 : Rebasing #

Patch Set 4 : Fixing rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -185 lines) Patch
M chrome/android/BUILD.gn View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/banners/app_banner_infobar_delegate.cc View 1 2 8 chunks +29 lines, -4 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager.cc View 1 2 6 chunks +7 lines, -12 lines 0 comments Download
D chrome/browser/android/banners/app_banner_metrics_id_list.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/android/banners/app_banner_metrics_ids.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/android/banners/app_banner_utilities.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/android/banners/app_banner_utilities.cc View 1 chunk +0 lines, -42 lines 0 comments Download
A chrome/browser/banners/app_banner_metrics.h View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A + chrome/browser/banners/app_banner_metrics.cc View 1 2 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/banners/app_banner_settings_helper.cc View 1 2 4 chunks +12 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +2 lines, -17 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
gone
5 years, 10 months ago (2015-02-13 22:12:52 UTC) #2
gone
benwells as FYI
5 years, 10 months ago (2015-02-13 22:14:30 UTC) #3
gone
Actually, reframing: Ben for the changes to AppBannerSettingsHelper & AppBannerManager Yusuf for the combination of ...
5 years, 10 months ago (2015-02-13 22:15:51 UTC) #5
benwells
AppBannerManager and AppBannerSettingsHelper lgtm
5 years, 10 months ago (2015-02-15 23:54:43 UTC) #6
gone
/me pokes Yusuf.
5 years, 10 months ago (2015-02-18 02:21:00 UTC) #7
Yusuf
On 2015/02/18 at 02:21:00, dfalcantara wrote: > /me pokes Yusuf. lgtm sorry for the delay.
5 years, 10 months ago (2015-02-18 22:49:38 UTC) #8
gone
isherman@chromium.org: Please review changes in histograms.xml cjhopman: Changes to BUILD.gn
5 years, 10 months ago (2015-02-18 23:02:22 UTC) #11
Ilya Sherman
histograms.xml lgtm
5 years, 10 months ago (2015-02-19 00:28:23 UTC) #12
cjhopman
lgtm
5 years, 10 months ago (2015-02-19 00:31:13 UTC) #13
gone
TBRing thakis@ for OWNERS on BUILD.gn and chrome.gyp
5 years, 10 months ago (2015-02-19 00:36:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929533002/60001
5 years, 10 months ago (2015-02-19 00:38:13 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-19 00:42:47 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 00:43:53 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/aada8ca53d972120510a5c0de6484d029e004e93
Cr-Commit-Position: refs/heads/master@{#316936}

Powered by Google App Engine
This is Rietveld 408576698