chrome/browser/android/banners/app_banner_metrics_id_list.h - Issue 929533002: [App banners] Add UMA metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_metrics_id_list.h

Issue 929533002: [App banners] Add UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner_cleanup

Patch Set: Fixing rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_manager.cc ('k') | chrome/browser/android/banners/app_banner_metrics_ids.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_metrics_id_list.h

diff --git a/chrome/browser/android/banners/app_banner_metrics_id_list.h b/chrome/browser/android/banners/app_banner_metrics_id_list.h

deleted file mode 100644

index 67edc18d38fb17ee47587980323046cdf63a79ed..0000000000000000000000000000000000000000

--- a/chrome/browser/android/banners/app_banner_metrics_id_list.h

+++ /dev/null

@@ -1,39 +0,0 @@

-// Use of this source code is governed by a BSD-style license that can be

-// found in the LICENSE file.

-#ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_METRICS_ID_LIST_H_

-#define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_METRICS_ID_LIST_H_

-// Keep in sync with the values defined in histograms.xml.

-DEFINE_APP_BANNER_METRICS_ID_ENUM_START(DisplayEvent)

-DEFINE_APP_BANNER_METRICS_ID(DISPLAY_MIN, 0)

-DEFINE_APP_BANNER_METRICS_ID(DISPLAY_BANNER_REQUESTED, 1)

-DEFINE_APP_BANNER_METRICS_ID(DISPLAY_BLOCKED_PREVIOUSLY, 2)

-DEFINE_APP_BANNER_METRICS_ID(DISPLAY_BLOCKED_TOO_MANY_OTHERS, 3)

-DEFINE_APP_BANNER_METRICS_ID(DISPLAY_CREATED, 4)

-DEFINE_APP_BANNER_METRICS_ID(DISPLAY_MAX, 5)

-DEFINE_APP_BANNER_METRICS_ID_ENUM_END()

-DEFINE_APP_BANNER_METRICS_ID_ENUM_START(InstallEvent)

-DEFINE_APP_BANNER_METRICS_ID(INSTALL_MIN, 20)

-DEFINE_APP_BANNER_METRICS_ID(INSTALL_TRIGGERED, 21)

-DEFINE_APP_BANNER_METRICS_ID(INSTALL_STARTED, 22)

-DEFINE_APP_BANNER_METRICS_ID(INSTALL_COMPLETED, 23)

-DEFINE_APP_BANNER_METRICS_ID(INSTALL_MAX, 24)

-DEFINE_APP_BANNER_METRICS_ID_ENUM_END()

-DEFINE_APP_BANNER_METRICS_ID_ENUM_START(DismissEvent)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_MIN, 40)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_ERROR, 41)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_APP_OPEN, 42)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_BANNER_CLICK, 43)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_BANNER_SWIPE, 44)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_CLOSE_BUTTON, 45)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_INSTALL_TIMEOUT, 46)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_NAVIGATE, 47)

-DEFINE_APP_BANNER_METRICS_ID(DISMISS_MAX, 48)

-DEFINE_APP_BANNER_METRICS_ID_ENUM_END()

-#endif // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_METRICS_ID_LIST_H_

« no previous file with comments | « chrome/browser/android/banners/app_banner_manager.cc ('k') | chrome/browser/android/banners/app_banner_metrics_ids.h » ('j') | no next file with comments »