Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 929533002: [App banners] Add UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner_cleanup
Patch Set: Fixing rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index bc94c61a0695ada9ac474e49eb17826e54ce7075..70c56b94109bb931fbbdf0538cbf038a2fa99ebf 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -263,7 +263,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="AppBanners.DismissEvent" enum="AppBannersDismissEvent">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>dfalcantara@chromium.org</owner>
<summary>
App banners promote an application related to the current website, and are
requested specifically through the current page's HTML. This stat tracks
@@ -273,7 +273,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="AppBanners.DisplayEvent" enum="AppBannersDisplayEvent">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>dfalcantara@chromium.org</owner>
<summary>
App banners promote an application related to the current website, and are
requested specifically through the current page's HTML. This stat tracks
@@ -283,7 +283,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="AppBanners.InstallEvent" enum="AppBannersInstallEvent">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>dfalcantara@chromium.org</owner>
<summary>
App banners promote an application related to the current website, and are
requested specifically through the current page's HTML. This stat tracks
@@ -43421,23 +43421,29 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="41" label="Error/unknown reason for dismissal"/>
<int value="42" label="User opened the application after installing it"/>
<int value="43" label="User clicked on the banner"/>
- <int value="44" label="User swiped the banner away"/>
+ <int value="44" label="(Obsolete) User swiped the banner away"/>
<int value="45" label="User hit the X button"/>
<int value="46" label="User began app install, but it didn't finish in time"/>
- <int value="47" label="Automatic dismissal: User navigated elsewhere"/>
+ <int value="47" label="Banner was dismissed for any reason"/>
</enum>
<enum name="AppBannersDisplayEvent" type="int">
<int value="1" label="Banner was requested by the site"/>
<int value="2" label="User previously blocked the same banner"/>
<int value="3" label="User blocked too many other banners from the site"/>
- <int value="4" label="Banner created."/>
+ <int value="4" label="Banner created"/>
+ <int value="5" label="User already installed the app"/>
+ <int value="6" label="User ignored the banner last time"/>
+ <int value="7" label="Manifest lacks a service worker"/>
+ <int value="8" label="Site hasn't been visited frequently enough"/>
</enum>
<enum name="AppBannersInstallEvent" type="int">
- <int value="21" label="User triggered the app install dialog"/>
- <int value="22" label="User began installing the app"/>
- <int value="23" label="User waited for the app to finish installing"/>
+ <int value="21" label="(Native app) User triggered the app install dialog"/>
+ <int value="22" label="(Native app) User began installing the app"/>
+ <int value="23"
+ label="(Native app) User waited for the app to finish installing"/>
+ <int value="24" label="(Web app) User installed a web app"/>
</enum>
<enum name="AppCacheCheckResponseResult" type="int">
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698