Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3667)

Unified Diff: chrome/chrome_browser.gypi

Issue 929533002: [App banners] Add UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner_cleanup
Patch Set: Fixing rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 7d894d439acdcabc4c152aeed3a81ed249c88abf..cf433a0c08f91990e26822a334a879e9e28ac287 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -33,10 +33,6 @@
'browser/android/banners/app_banner_infobar_delegate.h',
'browser/android/banners/app_banner_manager.cc',
'browser/android/banners/app_banner_manager.h',
- 'browser/android/banners/app_banner_metrics_id_list.h',
- 'browser/android/banners/app_banner_metrics_ids.h',
- 'browser/android/banners/app_banner_utilities.cc',
- 'browser/android/banners/app_banner_utilities.h',
'browser/android/bookmarks/bookmarks_bridge.cc',
'browser/android/bookmarks/bookmarks_bridge.h',
'browser/android/bookmarks/partner_bookmarks_reader.cc',
@@ -182,6 +178,8 @@
'browser/autofill/risk_util.h',
'browser/autofill/validation_rules_storage_factory.cc',
'browser/autofill/validation_rules_storage_factory.h',
+ 'browser/banners/app_banner_metrics.cc',
+ 'browser/banners/app_banner_metrics.h',
'browser/banners/app_banner_settings_helper.cc',
'browser/banners/app_banner_settings_helper.h',
'browser/bitmap_fetcher/bitmap_fetcher.cc',
@@ -3627,19 +3625,6 @@
'includes': [ '../build/android/java_cpp_enum.gypi' ],
},
{
- # GN: //chrome/android:app_banner_metrics_ids_javagen
- 'target_name': 'app_banner_metrics_ids_java',
- 'type': 'none',
- 'sources': [
- 'android/java/AppBannerMetricsIds.template',
- ],
- 'variables': {
- 'package_name': 'org/chromium/chrome/browser/banners',
- 'template_deps': ['browser/android/banners/app_banner_metrics_id_list.h'],
- },
- 'includes': [ '../build/android/java_cpp_template.gypi' ],
- },
- {
# GN: //chrome/android:resource_id_javagen
'target_name': 'resource_id_java',
'type': 'none',
« no previous file with comments | « chrome/chrome.gyp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698