|
Add [TypeChecking=Unrestricted] to Web Audio interfaces
This changes behavior when non-finite floating point values are assigned
to attributes or passed as arguments to methods, by throwing TypeError
exceptions. The old behavior was to throw InvalidStateError exceptions
in some cases, as required by the current spec, and to not throw anything
in other cases.
Since value checks are now done by the bindings layer, some checks can
be removed from or simplified in the Web Audio implementation.
The new behavior is required by the WebIDL spec and matches Firefox. There
is an (at the time of writing) open Web Audio bug to align it with WebIDL:
https://github.com/WebAudio/web-audio-api/issues/385
BUG= 354298
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190397
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+116 lines, -128 lines) |
Patch |
|
M |
LayoutTests/webaudio/audioparam-exceptional-values.html
|
View
|
|
2 chunks |
+22 lines, -18 lines |
0 comments
|
Download
|
|
M |
LayoutTests/webaudio/audioparam-exceptional-values-expected.txt
|
View
|
|
1 chunk |
+36 lines, -30 lines |
0 comments
|
Download
|
|
M |
LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/webaudio/dom-exceptions-expected.txt
|
View
|
|
2 chunks |
+22 lines, -22 lines |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AnalyserNode.idl
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioBufferSourceNode.cpp
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioBufferSourceNode.idl
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioContext.idl
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioListener.idl
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioParam.cpp
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioParam.idl
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioParamTimeline.cpp
|
View
|
|
9 chunks |
+10 lines, -35 lines |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/AudioScheduledSourceNode.cpp
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/DelayNode.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/OscillatorNode.idl
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/modules/webaudio/PannerNode.idl
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|