Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 927333004: Add [TypeChecking=Unrestricted] to Web Audio interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AnalyserNode.idl ('k') | Source/modules/webaudio/AudioBufferSourceNode.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioBufferSourceNode.cpp
diff --git a/Source/modules/webaudio/AudioBufferSourceNode.cpp b/Source/modules/webaudio/AudioBufferSourceNode.cpp
index 1315d60eb9d8657ec17cd59d23d06fd2f82ccfcd..488b8ba041c1a2493459b17bfc12935a261757dd 100644
--- a/Source/modules/webaudio/AudioBufferSourceNode.cpp
+++ b/Source/modules/webaudio/AudioBufferSourceNode.cpp
@@ -444,24 +444,24 @@ void AudioBufferSourceNode::start(double when, double grainOffset, double grainD
return;
}
- if (!std::isfinite(when) || (when < 0)) {
+ if (when < 0) {
exceptionState.throwDOMException(
InvalidStateError,
- "Start time must be a finite non-negative number: " + String::number(when));
+ "Start time must be a non-negative number: " + String::number(when));
return;
}
- if (!std::isfinite(grainOffset) || (grainOffset < 0)) {
+ if (grainOffset < 0) {
exceptionState.throwDOMException(
InvalidStateError,
- "Offset must be a finite non-negative number: " + String::number(grainOffset));
+ "Offset must be a non-negative number: " + String::number(grainOffset));
return;
}
- if (!std::isfinite(grainDuration) || (grainDuration < 0)) {
+ if (grainDuration < 0) {
exceptionState.throwDOMException(
InvalidStateError,
- "Duration must be a finite non-negative number: " + String::number(grainDuration));
+ "Duration must be a non-negative number: " + String::number(grainDuration));
return;
}
« no previous file with comments | « Source/modules/webaudio/AnalyserNode.idl ('k') | Source/modules/webaudio/AudioBufferSourceNode.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698