Source/modules/webaudio/DelayNode.cpp - Issue 927333004: Add [TypeChecking=Unrestricted] to Web Audio interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/DelayNode.cpp

Issue 927333004: Add [TypeChecking=Unrestricted] to Web Audio interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/DelayNode.cpp

diff --git a/Source/modules/webaudio/DelayNode.cpp b/Source/modules/webaudio/DelayNode.cpp

index a3aa590ba2d16e5b6dae0287ffa73a670fb4cd61..4ef19ad531f81f09465dce14cce170a75a980d29 100644

--- a/Source/modules/webaudio/DelayNode.cpp

+++ b/Source/modules/webaudio/DelayNode.cpp

@@ -40,7 +40,7 @@ const double maximumAllowedDelayTime = 180;

DelayNode::DelayNode(AudioContext* context, float sampleRate, double maxDelayTime, ExceptionState& exceptionState)

: AudioBasicProcessorNode(NodeTypeDelay, context, sampleRate)

{

- if (maxDelayTime <= 0 || maxDelayTime >= maximumAllowedDelayTime || std::isnan(maxDelayTime)) {

+ if (maxDelayTime <= 0 || maxDelayTime >= maximumAllowedDelayTime) {

exceptionState.throwDOMException(

NotSupportedError,

"max delay time (" + String::number(maxDelayTime)

« no previous file with comments | « Source/modules/webaudio/AudioScheduledSourceNode.cpp ('k') | Source/modules/webaudio/OscillatorNode.idl » ('j') | no next file with comments »