Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: Source/modules/webaudio/AudioScheduledSourceNode.cpp

Issue 927333004: Add [TypeChecking=Unrestricted] to Web Audio interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webaudio/AudioParamTimeline.cpp ('k') | Source/modules/webaudio/DelayNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioScheduledSourceNode.cpp
diff --git a/Source/modules/webaudio/AudioScheduledSourceNode.cpp b/Source/modules/webaudio/AudioScheduledSourceNode.cpp
index 52d0ed3ab5d92dee5f9169adb5615847f0f89dd0..19ba26d8c63b74b45c2e77a686e4d50a6fd9589c 100644
--- a/Source/modules/webaudio/AudioScheduledSourceNode.cpp
+++ b/Source/modules/webaudio/AudioScheduledSourceNode.cpp
@@ -145,7 +145,7 @@ void AudioScheduledSourceNode::start(double when, ExceptionState& exceptionState
return;
}
- if (!std::isfinite(when) || (when < 0)) {
+ if (when < 0) {
exceptionState.throwDOMException(
InvalidAccessError,
"Start time must be a finite non-negative number: " + String::number(when));
@@ -172,10 +172,10 @@ void AudioScheduledSourceNode::stop(double when, ExceptionState& exceptionState)
return;
}
- if (!std::isfinite(when) || (when < 0)) {
+ if (when < 0) {
exceptionState.throwDOMException(
InvalidAccessError,
- "Stop time must be a finite non-negative number: " + String::number(when));
+ "Stop time must be a non-negative number: " + String::number(when));
return;
}
« no previous file with comments | « Source/modules/webaudio/AudioParamTimeline.cpp ('k') | Source/modules/webaudio/DelayNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698