Adding support for storing webrtc logs locally with an extension supplied unique id, for later uplo…

Adding support for storing webrtc logs locally with an extension supplied unique id, for later upload.
This approach has two new methods:
  * store() - allows the application to specify an ID for the log file that will be stored locally, but not uploaded.  The file can be stored for up to 5 days.
  * uploadStored() - allows the application to upload a previously stored log file.

Refactoring the code for less copy/paste.

BUG=459750
Committed: https://crrev.com/ea8bd3ec56864669aafd76247f2e0f7b0160b590
Cr-Commit-Position: refs/heads/master@{#317309}

[tommi (sloooow) - chröme, 2015-02-17 20:26:01]

Refactor the function classes a bit

[tommi (sloooow) - chröme, 2015-02-17 23:08:38]

Refactored quite a bit.  One more test running, storing the native log now.

[tommi (sloooow) - chröme, 2015-02-18 13:44:53]

Tons of refactoring to be able to reuse the uploading code for stored
logs/metadata

[tommi (sloooow) - chröme, 2015-02-18 14:02:10]

Remove unused param

[tommi (sloooow) - chröme, 2015-02-18 14:23:56]

Update unit_tests target

[tommi (sloooow) - chröme, 2015-02-18 16:58:39]

Upload test passing

[tommi (sloooow) - chröme, 2015-02-18 20:56:44]

Add support for rtp dumps

[tommi (sloooow) - chröme, 2015-02-18 21:43:30]

Add support for meta data

[tommi (sloooow) - chröme, 2015-02-18 21:52:11]

Rebase

[tommi (sloooow) - chröme, 2015-02-18 21:57:13]

tommi@chromium.org changed reviewers:
+ perkj@chromium.org

[tommi (sloooow) - chröme, 2015-02-18 21:58:10]

Hej Per - sorry about this rather large review.  I had to refactor the code
quite a bit to be able to re-use some of the functionality that's in there. 
There's a lot of removal of copy/paste code and moving code around.

[tommi (sloooow) - chröme, 2015-02-18 22:08:19]

Remove leftover comments

[tommi (sloooow) - chröme, 2015-02-19 08:11:02]

Change how we read from WebRtcLogBuffer

[tommi (sloooow) - chröme, 2015-02-19 09:46:15]

Rebase

[perkj_chrome, 2015-02-19 11:55:54]

lgtm with some nits.

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
(right):

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc:10:
#include "base/strings/string_number_conversions.h"
duplicate include

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
File chrome/browser/media/webrtc_log_uploader.cc (right):

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
chrome/browser/media/webrtc_log_uploader.cc:401: PartialCircularBuffer
read_buffer = buffer->Read();
nit ()

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
chrome/browser/media/webrtc_log_uploader.cc:405:
kIntermediateCompressionBufferBytes);
sizeof(intermediate_buffer)

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
File chrome/browser/media/webrtc_log_uploader_unittest.cc (right):

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
chrome/browser/media/webrtc_log_uploader_unittest.cc:257:
scoped_ptr<MetaDataMap>(new MetaDataMap()).Pass(),
nit make_scoped_ptr

https://codereview.chromium.org/927233005/diff/240001/chrome/common/extension...
File chrome/common/extensions/api/webrtc_logging_private.idl (right):

https://codereview.chromium.org/927233005/diff/240001/chrome/common/extension...
chrome/common/extensions/api/webrtc_logging_private.idl:71: // as much as 5
days.  The application has the option of supplying an id
nit remove extra space

[tommi (sloooow) - chröme, 2015-02-19 12:59:40]

New patchsets have been uploaded after l-g-t-m from perkj@chromium.org

[tommi (sloooow) - chröme, 2015-02-19 12:59:42]

Address comments

[tommi (sloooow) - chröme, 2015-02-19 13:31:39]

tommi@chromium.org changed reviewers:
+ finnur@chromium.org, isherman@chromium.org

[tommi (sloooow) - chröme, 2015-02-19 13:31:41]

+finnur as extension owner
+isherman for histograms.xml

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/extensio...
File
chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
(right):

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/extensio...
chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc:10:
#include "base/strings/string_number_conversions.h"
On 2015/02/19 11:55:53, perkj wrote:
> duplicate include

Done.

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
File chrome/browser/media/webrtc_log_uploader.cc (right):

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
chrome/browser/media/webrtc_log_uploader.cc:401: PartialCircularBuffer
read_buffer = buffer->Read();
On 2015/02/19 11:55:53, perkj wrote:
> nit ()

Done.

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
chrome/browser/media/webrtc_log_uploader.cc:405:
kIntermediateCompressionBufferBytes);
On 2015/02/19 11:55:53, perkj wrote:
> sizeof(intermediate_buffer)

Done.

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
File chrome/browser/media/webrtc_log_uploader_unittest.cc (right):

https://codereview.chromium.org/927233005/diff/240001/chrome/browser/media/we...
chrome/browser/media/webrtc_log_uploader_unittest.cc:257:
scoped_ptr<MetaDataMap>(new MetaDataMap()).Pass(),
On 2015/02/19 11:55:53, perkj wrote:
> nit make_scoped_ptr

Done.

https://codereview.chromium.org/927233005/diff/240001/chrome/common/extension...
File chrome/common/extensions/api/webrtc_logging_private.idl (right):

https://codereview.chromium.org/927233005/diff/240001/chrome/common/extension...
chrome/common/extensions/api/webrtc_logging_private.idl:71: // as much as 5
days.  The application has the option of supplying an id
On 2015/02/19 11:55:53, perkj wrote:
> nit remove extra space

Done.

[Ilya Sherman, 2015-02-19 20:24:07]

histograms lgtm

[Finnur, 2015-02-20 10:59:16]

I'll leave the correctness of WebRtc code up to you guys but leave you with a
rubberstamp LGTM from an extension standpoint.

[tommi (sloooow) - chröme, 2015-02-20 12:22:10]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2015-02-20 12:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927233005/260001

[commit-bot: I haz the power, 2015-02-20 12:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 12:39:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommi (sloooow) - chröme, 2015-02-20 12:45:35]

New patchsets have been uploaded after l-g-t-m from
isherman@chromium.org,finnur@chromium.org

[tommi (sloooow) - chröme, 2015-02-20 12:45:38]

Rebase

[tommi (sloooow) - chröme, 2015-02-20 12:50:58]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2015-02-20 12:51:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/927233005/280001

[commit-bot: I haz the power, 2015-02-20 13:50:02]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2015-02-20 13:50:47]

Patchset 15 (id:??) landed as
https://crrev.com/ea8bd3ec56864669aafd76247f2e0f7b0160b590
Cr-Commit-Position: refs/heads/master@{#317309}