Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc

Issue 927233005: Adding support for storing webrtc logs locally with an extension supplied unique id, for later uplo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc
diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc
index 6a55645a0a29d96fd60160d1c3aca8072cbee832..836e06b19b73528bc7e4064a3364d2cb0134f5ec 100644
--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc
+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc
@@ -14,93 +14,52 @@ const char kErrorNotSupported[] = "Not supported";
} // namespace
-WebrtcLoggingPrivateSetMetaDataFunction::
-WebrtcLoggingPrivateSetMetaDataFunction() {}
-
-WebrtcLoggingPrivateSetMetaDataFunction::
-~WebrtcLoggingPrivateSetMetaDataFunction() {}
-
bool WebrtcLoggingPrivateSetMetaDataFunction::RunAsync() {
SetError(kErrorNotSupported);
SendResponse(false);
return false;
}
-void WebrtcLoggingPrivateSetMetaDataFunction::SetMetaDataCallback(
- bool success, const std::string& error_message) {}
-
-WebrtcLoggingPrivateStartFunction::WebrtcLoggingPrivateStartFunction() {}
-
-WebrtcLoggingPrivateStartFunction::~WebrtcLoggingPrivateStartFunction() {}
-
bool WebrtcLoggingPrivateStartFunction::RunAsync() {
SetError(kErrorNotSupported);
SendResponse(false);
return false;
}
-void WebrtcLoggingPrivateStartFunction::StartCallback(
- bool success, const std::string& error_message) {}
-
-WebrtcLoggingPrivateSetUploadOnRenderCloseFunction::
-WebrtcLoggingPrivateSetUploadOnRenderCloseFunction() {}
-
-WebrtcLoggingPrivateSetUploadOnRenderCloseFunction::
-~WebrtcLoggingPrivateSetUploadOnRenderCloseFunction() {}
-
bool WebrtcLoggingPrivateSetUploadOnRenderCloseFunction::RunAsync() {
SetError(kErrorNotSupported);
SendResponse(false);
return false;
}
-WebrtcLoggingPrivateStopFunction::WebrtcLoggingPrivateStopFunction() {}
-
-WebrtcLoggingPrivateStopFunction::~WebrtcLoggingPrivateStopFunction() {}
-
bool WebrtcLoggingPrivateStopFunction::RunAsync() {
SetError(kErrorNotSupported);
SendResponse(false);
return false;
}
-void WebrtcLoggingPrivateStopFunction::StopCallback(
- bool success, const std::string& error_message) {}
-
-WebrtcLoggingPrivateUploadFunction::WebrtcLoggingPrivateUploadFunction() {}
-
-WebrtcLoggingPrivateUploadFunction::~WebrtcLoggingPrivateUploadFunction() {}
-
-bool WebrtcLoggingPrivateUploadFunction::RunAsync() {
+bool WebrtcLoggingPrivateStoreFunction::RunAsync() {
SetError(kErrorNotSupported);
SendResponse(false);
return false;
}
-void WebrtcLoggingPrivateUploadFunction::UploadCallback(
- bool success, const std::string& report_id,
- const std::string& error_message) {
-}
-
-WebrtcLoggingPrivateDiscardFunction::WebrtcLoggingPrivateDiscardFunction() {}
-
-WebrtcLoggingPrivateDiscardFunction::~WebrtcLoggingPrivateDiscardFunction() {}
-
-bool WebrtcLoggingPrivateDiscardFunction::RunAsync() {
+bool WebrtcLoggingPrivateUploadStoredFunction::RunAsync() {
SetError(kErrorNotSupported);
SendResponse(false);
return false;
}
-void WebrtcLoggingPrivateDiscardFunction::DiscardCallback(
- bool success, const std::string& error_message) {}
-
-WebrtcLoggingPrivateStartRtpDumpFunction::
- WebrtcLoggingPrivateStartRtpDumpFunction() {
+bool WebrtcLoggingPrivateUploadFunction::RunAsync() {
+ SetError(kErrorNotSupported);
+ SendResponse(false);
+ return false;
}
-WebrtcLoggingPrivateStartRtpDumpFunction::
- ~WebrtcLoggingPrivateStartRtpDumpFunction() {
+bool WebrtcLoggingPrivateDiscardFunction::RunAsync() {
+ SetError(kErrorNotSupported);
+ SendResponse(false);
+ return false;
}
bool WebrtcLoggingPrivateStartRtpDumpFunction::RunAsync() {
@@ -109,28 +68,10 @@ bool WebrtcLoggingPrivateStartRtpDumpFunction::RunAsync() {
return false;
}
-void WebrtcLoggingPrivateStartRtpDumpFunction::StartRtpDumpCallback(
- bool success,
- const std::string& error_message) {
-}
-
-WebrtcLoggingPrivateStopRtpDumpFunction::
- WebrtcLoggingPrivateStopRtpDumpFunction() {
-}
-
-WebrtcLoggingPrivateStopRtpDumpFunction::
- ~WebrtcLoggingPrivateStopRtpDumpFunction() {
-}
-
bool WebrtcLoggingPrivateStopRtpDumpFunction::RunAsync() {
SetError(kErrorNotSupported);
SendResponse(false);
return false;
}
-void WebrtcLoggingPrivateStopRtpDumpFunction::StopRtpDumpCallback(
- bool success,
- const std::string& error_message) {
-}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698