Adding support for storing webrtc logs locally with an extension supplied unique id, for later uplo…

chrome/browser/media/webrtc_log_uploader_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 232 matching lines @@
   base::WriteFile(outgoing_dump,
                   &outgoing_dump_content[0],
                   outgoing_dump_content.size());
 
   WebRtcLogUploadDoneData upload_done_data;
   upload_done_data.log_path = temp_dir.path().AppendASCII("log");
 
   upload_done_data.incoming_rtp_dump = incoming_dump;
   upload_done_data.outgoing_rtp_dump = outgoing_dump;
 
-  const size_t log_length = 100;
-  scoped_ptr<unsigned char[]> log(new unsigned char[log_length]);
-  memset(log.get(), 0, log_length);
-
+  scoped_ptr<WebRtcLogBuffer> log(new WebRtcLogBuffer());
+  log->SetComplete();
   webrtc_log_uploader->LoggingStoppedDoUpload(
       log.Pass(),
-      log_length,
-      std::map<std::string, std::string>(),
+      scoped_ptr<MetaDataMap>(new MetaDataMap()).Pass(),

[perkj_chrome, 2015/02/19 11:55:53]

nit make_scoped_ptr

[tommi (sloooow) - chröme, 2015/02/19 13:31:41]

Done.

       upload_done_data);
 
   VerifyRtpDumpInMultipart(post_data, "rtpdump_recv", incoming_dump_content);
   VerifyRtpDumpInMultipart(post_data, "rtpdump_send", outgoing_dump_content);
 
   webrtc_log_uploader->StartShutdown();
 }