Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/media/webrtc_log_uploader_unittest.cc

Issue 927233005: Adding support for storing webrtc logs locally with an extension supplied unique id, for later uplo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc_log_uploader.cc ('k') | chrome/browser/media/webrtc_logging_handler_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_log_uploader_unittest.cc
diff --git a/chrome/browser/media/webrtc_log_uploader_unittest.cc b/chrome/browser/media/webrtc_log_uploader_unittest.cc
index 4b60b39d0f857bef657a4f56a7774fa4538fc80b..2994c8bc42107f94f69bb86f12b1c1180a102abd 100644
--- a/chrome/browser/media/webrtc_log_uploader_unittest.cc
+++ b/chrome/browser/media/webrtc_log_uploader_unittest.cc
@@ -250,15 +250,10 @@ TEST_F(WebRtcLogUploaderTest, AddRtpDumpsToPostedData) {
upload_done_data.incoming_rtp_dump = incoming_dump;
upload_done_data.outgoing_rtp_dump = outgoing_dump;
- const size_t log_length = 100;
- scoped_ptr<unsigned char[]> log(new unsigned char[log_length]);
- memset(log.get(), 0, log_length);
-
+ scoped_ptr<WebRtcLogBuffer> log(new WebRtcLogBuffer());
+ log->SetComplete();
webrtc_log_uploader->LoggingStoppedDoUpload(
- log.Pass(),
- log_length,
- std::map<std::string, std::string>(),
- upload_done_data);
+ log.Pass(), make_scoped_ptr(new MetaDataMap()), upload_done_data);
VerifyRtpDumpInMultipart(post_data, "rtpdump_recv", incoming_dump_content);
VerifyRtpDumpInMultipart(post_data, "rtpdump_send", outgoing_dump_content);
« no previous file with comments | « chrome/browser/media/webrtc_log_uploader.cc ('k') | chrome/browser/media/webrtc_logging_handler_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698