Cleanup: Convert const char* kFoo to const char kFoo[].

Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.

TBR=cpu@chromium.org

Committed: https://crrev.com/53c883cd322c07f257aa8557549e91598e62fc3f
Cr-Commit-Position: refs/heads/master@{#365692}

[Lei Zhang, 2015-02-13 20:13:12]

thestig@chromium.org changed reviewers:
+ tommycli@chromium.org

[Lei Zhang, 2015-02-13 20:13:12]

I'll TBR the other owners since this is pretty mechanical.

[tommycli, 2015-02-13 20:22:37]

lgtm

https://codereview.chromium.org/924793003/diff/1/sandbox/linux/suid/common/su...
File sandbox/linux/suid/common/suid_unsafe_environment_variables.h (right):

https://codereview.chromium.org/924793003/diff/1/sandbox/linux/suid/common/su...
sandbox/linux/suid/common/suid_unsafe_environment_variables.h:23: static const
char* const kSUIDUnsafeEnvironmentVariables[] = {
I take it char kFoo[][] = { ... } is not legal C?

[jln (very slow on Chromium), 2015-02-13 20:22:44]

On 2015/02/13 20:13:12, Lei Zhang wrote:
> I'll TBR the other owners since this is pretty mechanical.

Shouldn't this be restricted to static const char kFoo[] = "blah"; ?

When it's an automatic variable, const char* kFoo = "blah"; is slightly better
than const char kFoo[] = "blah"; because it doesn't involve building "blah" on
the stack.

[Lei Zhang, 2015-12-08 10:41:49]

Description was changed from

==========
Cleanup: Convert const char* kFoo to const char kFoo[].
==========

to

==========
Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.
==========

[Lei Zhang, 2015-12-08 17:51:15]

(Dug this up because it was buried but unread in my reviews folder)

It's all static variables, and a few const char* -> const char* const.

Most of the patch still applied at ToT 10 months later.

On 2015/02/13 20:22:44, jln (slow on Chromium) wrote:
> On 2015/02/13 20:13:12, Lei Zhang wrote:
> > I'll TBR the other owners since this is pretty mechanical.
> 
> Shouldn't this be restricted to static const char kFoo[] = "blah"; ?
> 
> When it's an automatic variable, const char* kFoo = "blah"; is slightly better
> than const char kFoo[] = "blah"; because it doesn't involve building "blah" on
> the stack.

[Lei Zhang, 2015-12-17 00:12:38]

Description was changed from

==========
Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.
==========

to

==========
Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.

TBR=cpu@chromium.org
==========

[Lei Zhang, 2015-12-17 00:12:38]

thestig@chromium.org changed reviewers:
+ cpu@chromium.org

[Lei Zhang, 2015-12-17 01:04:23]

TBRing cpu@ for components-sandbox

[Lei Zhang, 2015-12-17 01:04:30]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-12-17 01:04:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/924793003/#ps40001 (title:
"rebase again")

[commit-bot: I haz the power, 2015-12-17 02:35:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/924793003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/924793003/40001

[commit-bot: I haz the power, 2015-12-17 03:09:39]

Description was changed from

==========
Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.

TBR=cpu@chromium.org
==========

to

==========
Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.

TBR=cpu@chromium.org
==========

[commit-bot: I haz the power, 2015-12-17 03:09:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-17 03:10:56]

Description was changed from

==========
Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.

TBR=cpu@chromium.org
==========

to

==========
Cleanup: Convert const char* kFoo to const char kFoo[].

Or change them to const char* const kFoo.

TBR=cpu@chromium.org

Committed: https://crrev.com/53c883cd322c07f257aa8557549e91598e62fc3f
Cr-Commit-Position: refs/heads/master@{#365692}
==========

[commit-bot: I haz the power, 2015-12-17 03:10:57]

Patchset 3 (id:??) landed as
https://crrev.com/53c883cd322c07f257aa8557549e91598e62fc3f
Cr-Commit-Position: refs/heads/master@{#365692}