Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: components/bookmarks/browser/bookmark_codec.h

Issue 924793003: Cleanup: Convert const char* kFoo to const char kFoo[]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/themes/theme_service.cc ('k') | components/bookmarks/browser/bookmark_codec.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_ 5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_
6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_ 6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // Return the sync transaction version of the bookmark model root. 79 // Return the sync transaction version of the bookmark model root.
80 int64_t model_sync_transaction_version() const { 80 int64_t model_sync_transaction_version() const {
81 return model_sync_transaction_version_; 81 return model_sync_transaction_version_;
82 } 82 }
83 83
84 // Returns whether the IDs were reassigned during decoding. Always returns 84 // Returns whether the IDs were reassigned during decoding. Always returns
85 // false after encoding. 85 // false after encoding.
86 bool ids_reassigned() const { return ids_reassigned_; } 86 bool ids_reassigned() const { return ids_reassigned_; }
87 87
88 // Names of the various keys written to the Value. 88 // Names of the various keys written to the Value.
89 static const char* kRootsKey; 89 static const char kRootsKey[];
90 static const char* kRootFolderNameKey; 90 static const char kRootFolderNameKey[];
91 static const char* kOtherBookmarkFolderNameKey; 91 static const char kOtherBookmarkFolderNameKey[];
92 static const char* kMobileBookmarkFolderNameKey; 92 static const char kMobileBookmarkFolderNameKey[];
93 static const char* kVersionKey; 93 static const char kVersionKey[];
94 static const char* kChecksumKey; 94 static const char kChecksumKey[];
95 static const char* kIdKey; 95 static const char kIdKey[];
96 static const char* kTypeKey; 96 static const char kTypeKey[];
97 static const char* kNameKey; 97 static const char kNameKey[];
98 static const char* kDateAddedKey; 98 static const char kDateAddedKey[];
99 static const char* kURLKey; 99 static const char kURLKey[];
100 static const char* kDateModifiedKey; 100 static const char kDateModifiedKey[];
101 static const char* kChildrenKey; 101 static const char kChildrenKey[];
102 static const char* kMetaInfo; 102 static const char kMetaInfo[];
103 static const char* kSyncTransactionVersion; 103 static const char kSyncTransactionVersion[];
104 104
105 // Possible values for kTypeKey. 105 // Possible values for kTypeKey.
106 static const char* kTypeURL; 106 static const char kTypeURL[];
107 static const char* kTypeFolder; 107 static const char kTypeFolder[];
108 108
109 private: 109 private:
110 // Encodes node and all its children into a Value object and returns it. 110 // Encodes node and all its children into a Value object and returns it.
111 // The caller takes ownership of the returned object. 111 // The caller takes ownership of the returned object.
112 base::Value* EncodeNode(const BookmarkNode* node); 112 base::Value* EncodeNode(const BookmarkNode* node);
113 113
114 // Encodes the given meta info into a Value object and returns it. The caller 114 // Encodes the given meta info into a Value object and returns it. The caller
115 // takes ownership of the returned object. 115 // takes ownership of the returned object.
116 base::Value* EncodeMetaInfo(const BookmarkNode::MetaInfoMap& meta_info_map); 116 base::Value* EncodeMetaInfo(const BookmarkNode::MetaInfoMap& meta_info_map);
117 117
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 203
204 // Sync transaction version set on bookmark model root. 204 // Sync transaction version set on bookmark model root.
205 int64_t model_sync_transaction_version_; 205 int64_t model_sync_transaction_version_;
206 206
207 DISALLOW_COPY_AND_ASSIGN(BookmarkCodec); 207 DISALLOW_COPY_AND_ASSIGN(BookmarkCodec);
208 }; 208 };
209 209
210 } // namespace bookmarks 210 } // namespace bookmarks
211 211
212 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_ 212 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_
OLDNEW
« no previous file with comments | « chrome/browser/themes/theme_service.cc ('k') | components/bookmarks/browser/bookmark_codec.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698