Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: chrome/browser/net/dns_probe_runner.h

Issue 924793003: Cleanup: Convert const char* kFoo to const char kFoo[]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_DNS_PROBE_RUNNER_H_ 5 #ifndef CHROME_BROWSER_NET_DNS_PROBE_RUNNER_H_
6 #define CHROME_BROWSER_NET_DNS_PROBE_RUNNER_H_ 6 #define CHROME_BROWSER_NET_DNS_PROBE_RUNNER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/memory/weak_ptr.h" 11 #include "base/memory/weak_ptr.h"
12 12
13 namespace net { 13 namespace net {
14 class DnsClient; 14 class DnsClient;
15 class DnsResponse; 15 class DnsResponse;
16 class DnsTransaction; 16 class DnsTransaction;
17 } 17 }
18 18
19 namespace chrome_browser_net { 19 namespace chrome_browser_net {
20 20
21 // Runs DNS probes using a single DnsClient and evaluates the responses. 21 // Runs DNS probes using a single DnsClient and evaluates the responses.
22 // (Currently requests A records for google.com and expects at least one IP 22 // (Currently requests A records for google.com and expects at least one IP
23 // address in the response.) 23 // address in the response.)
24 // Used by DnsProbeService to probe the system and public DNS configurations. 24 // Used by DnsProbeService to probe the system and public DNS configurations.
25 class DnsProbeRunner { 25 class DnsProbeRunner {
26 public: 26 public:
27 static const char* kKnownGoodHostname; 27 static const char kKnownGoodHostname[];
28 28
29 // Used in histograms; add new entries at the bottom, and don't remove any. 29 // Used in histograms; add new entries at the bottom, and don't remove any.
30 enum Result { 30 enum Result {
31 UNKNOWN, 31 UNKNOWN,
32 CORRECT, // Response contains at least one A record. 32 CORRECT, // Response contains at least one A record.
33 INCORRECT, // Response claimed success but included no A records. 33 INCORRECT, // Response claimed success but included no A records.
34 FAILING, // Response included an error or was malformed. 34 FAILING, // Response included an error or was malformed.
35 UNREACHABLE // No response received (timeout, network unreachable, etc.). 35 UNREACHABLE // No response received (timeout, network unreachable, etc.).
36 }; 36 };
37 37
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 Result result_; 76 Result result_;
77 77
78 base::WeakPtrFactory<DnsProbeRunner> weak_factory_; 78 base::WeakPtrFactory<DnsProbeRunner> weak_factory_;
79 79
80 DISALLOW_COPY_AND_ASSIGN(DnsProbeRunner); 80 DISALLOW_COPY_AND_ASSIGN(DnsProbeRunner);
81 }; 81 };
82 82
83 } // namespace chrome_browser_net 83 } // namespace chrome_browser_net
84 84
85 #endif // CHROME_BROWSER_NET_DNS_PROBE_RUNNER_H_ 85 #endif // CHROME_BROWSER_NET_DNS_PROBE_RUNNER_H_
OLDNEW
« no previous file with comments | « chrome/browser/content_settings/content_settings_browsertest.cc ('k') | chrome/browser/net/dns_probe_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698