Cleanup: Convert const char* kFoo to const char kFoo[].

sandbox/linux/suid/common/suid_unsafe_environment_variables.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is a list of environment variables which the ELF loader unsets when
 // loading a SUID binary. Because they are unset rather than just ignored, they
 // aren't passed to child processes of SUID processes either.
 //
 // We need to save these environment variables before running a SUID sandbox
 // and restore them before running child processes (but after dropping root).
 //
 // List gathered from glibc sources (00ebd7ed58df389a78e41dece058048725cb585e):
 //   sysdeps/unix/sysv/linux/i386/dl-librecon.h
 //   sysdeps/generic/unsecvars.h
 
-#ifndef SANDBOX_LINUX_SUID_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
-#define SANDBOX_LINUX_SUID_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
+#ifndef SANDBOX_LINUX_SUID_COMMON_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
+#define SANDBOX_LINUX_SUID_COMMON_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
 
 #include <stdint.h>
 #include <stdlib.h>  // malloc
 #include <string.h>  // memcpy
 
-static const char* kSUIDUnsafeEnvironmentVariables[] = {
+static const char* const kSUIDUnsafeEnvironmentVariables[] = {

[tommycli, 2015/02/13 20:22:37]

I take it char kFoo[][] = { ... } is not legal C?

   "LD_AOUT_LIBRARY_PATH",
   "LD_AOUT_PRELOAD",
   "GCONV_PATH",
   "GETCONF_DIR",
   "HOSTALIASES",
   "LD_AUDIT",
   "LD_DEBUG",
   "LD_DEBUG_OUTPUT",
   "LD_DYNAMIC_WEAK",
   "LD_LIBRARY_PATH",
@@ skipping 29 matching lines @@
   if (!saved_envvar)
     return NULL;
 
   memcpy(saved_envvar, "SANDBOX_", 8);
   memcpy(saved_envvar + 8, envvar, envvar_len);
   saved_envvar[8 + envvar_len] = 0;
 
   return saved_envvar;
 }
 
-#endif  // SANDBOX_LINUX_SUID_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
+#endif  // SANDBOX_LINUX_SUID_COMMON_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_