Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 92153003: Rename RenderViewHostManager to RenderFrameHostManager. (Closed)

Created:
7 years ago by Charlie Reis
Modified:
7 years ago
Reviewers:
nduca, nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Rename RenderViewHostManager to RenderFrameHostManager. BUG=314791 TEST=No behavior change. TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237714

Patch Set 1 #

Patch Set 2 : Update other references #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -4417 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/reliability/known_crashes.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 5 chunks +6 lines, -7 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/frame_host/render_frame_host_manager.h View 5 chunks +11 lines, -12 lines 0 comments Download
A + content/browser/frame_host/render_frame_host_manager.cc View 32 chunks +42 lines, -42 lines 0 comments Download
A + content/browser/frame_host/render_frame_host_manager_browsertest.cc View 23 chunks +24 lines, -24 lines 0 comments Download
A + content/browser/frame_host/render_frame_host_manager_unittest.cc View 36 chunks +54 lines, -54 lines 0 comments Download
D content/browser/frame_host/render_view_host_manager.h View 1 chunk +0 lines, -407 lines 0 comments Download
D content/browser/frame_host/render_view_host_manager.cc View 1 chunk +0 lines, -1148 lines 0 comments Download
D content/browser/frame_host/render_view_host_manager_unittest.cc View 1 chunk +0 lines, -1319 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
D content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +0 lines, -1361 lines 0 comments Download
M content/browser/site_instance_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M content/browser/webui/web_ui_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/heapcheck/suppressions.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Charlie Reis
Nasko, do you have time to review? This is just a rename before we make ...
7 years ago (2013-11-27 19:09:07 UTC) #1
nasko
LGTM
7 years ago (2013-11-27 19:59:44 UTC) #2
Charlie Reis
Nat, can you review the comment change in tools/telemetry/telemetry/page/page_runner.py for OWNERs?
7 years ago (2013-11-27 20:25:14 UTC) #3
Charlie Reis
On 2013/11/27 20:25:14, creis wrote: > Nat, can you review the comment change in > ...
7 years ago (2013-11-27 22:13:48 UTC) #4
nduca
lgtm wow, owners-soup
7 years ago (2013-11-27 22:49:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/92153003/40001
7 years ago (2013-11-27 23:42:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/92153003/40001
7 years ago (2013-11-28 02:52:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/92153003/40001
7 years ago (2013-11-28 03:19:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/92153003/40001
7 years ago (2013-11-28 03:41:43 UTC) #9
commit-bot: I haz the power
7 years ago (2013-11-28 06:47:38 UTC) #10
Message was sent while issue was closed. 
Change committed as 237714

Powered by Google App Engine
This is Rietveld 408576698