tools/telemetry/telemetry/page/page_runner.py - Issue 92153003: Rename RenderViewHostManager to RenderFrameHostManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 92153003: Rename RenderViewHostManager to RenderFrameHostManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 82d7efebe4abd3f9bf08cee743c162f3897c2a76..7d1f024131efed0a115c2836ef96000e051bb4a5 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -93,7 +93,7 @@ class _RunState(object):

self.browser.tabs[-1].Close()

# Must wait for tab to commit otherwise it can commit after the next

- # navigation has begun and RenderViewHostManager::DidNavigateMainFrame()

+ # navigation has begun and RenderFrameHostManager::DidNavigateMainFrame()

# will cancel the next navigation because it's pending. This manifests as

# the first navigation in a PageSet freezing indefinitly because the

# navigation was silently cancelled when |self.browser.tabs[0]| was

« no previous file with comments | « tools/heapcheck/suppressions.txt ('k') | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »