Add glGetActiveUniformsiv to GPU command buffer.

Add glGetActiveUniformsiv to GPU command buffer.

To improve performance, again we try to fetch all the info once through
an internal command glGetUniformsES3CHROMIUM.  Basically it gets all the
information that can be provided by glGetActiveUniformsiv except for those
that can already be queried through glGetActiveUniform, which will be cached
on the client side through internal command glGetProgramInfoCHROMIUM.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
NOTRY=true

Committed: https://crrev.com/c7e7e13f022f30f6b3eefd919881cb57513dca40
Cr-Commit-Position: refs/heads/master@{#316666}

[Zhenyao Mo, 2015-02-14 00:37:21]

Patchset #6 (id:90001) has been deleted

[Zhenyao Mo, 2015-02-14 00:37:28]

Patchset #5 (id:70001) has been deleted

[Zhenyao Mo, 2015-02-14 00:37:36]

Patchset #4 (id:50026) has been deleted

[Zhenyao Mo, 2015-02-14 00:37:40]

Patchset #3 (id:40001) has been deleted

[Zhenyao Mo, 2015-02-14 00:37:50]

Patchset #2 (id:20001) has been deleted

[Zhenyao Mo, 2015-02-14 00:37:57]

Patchset #1 (id:1) has been deleted

[Zhenyao Mo, 2015-02-17 19:24:24]

piman: please take a look.
Others: FYI (feel free to review).

[piman, 2015-02-17 19:39:35]

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.cc:1554: if (count == 0) {
Don't we need to send a bucket with the header with 0 in it?

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.cc:1587: const size_t kNumIterations
= arraysize(kPname);
nit: "Iteration" is kind of not very descriptive. kNumParams? kNumPNames?

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.cc:1593: for (size_t iter = 0; iter <
kNumIterations; ++iter) {
nit: same wrt "iter". param?

[Zhenyao Mo, 2015-02-17 19:59:42]

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.cc:1554: if (count == 0) {
On 2015/02/17 19:39:35, piman (Very slow to review) wrote:
> Don't we need to send a bucket with the header with 0 in it?

In bucket->SetSize, all data init to 0.  So no need to reset num_uniforms here.

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.cc:1587: const size_t kNumIterations
= arraysize(kPname);
On 2015/02/17 19:39:35, piman (Very slow to review) wrote:
> nit: "Iteration" is kind of not very descriptive. kNumParams? kNumPNames?

Done.

https://codereview.chromium.org/921023002/diff/170001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.cc:1593: for (size_t iter = 0; iter <
kNumIterations; ++iter) {
On 2015/02/17 19:39:35, piman (Very slow to review) wrote:
> nit: same wrt "iter". param?

Done.

[piman, 2015-02-17 20:29:44]

OK, LGTM

[Zhenyao Mo, 2015-02-17 20:37:20]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2015-02-17 20:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921023002/210001

[commit-bot: I haz the power, 2015-02-17 21:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-17 21:47:58]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[Zhenyao Mo, 2015-02-17 22:03:37]

On 2015/02/17 21:47:58, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

Failure on android_rel_tests_recipe is irrelevant, landing with NOTRY=true

[Zhenyao Mo, 2015-02-17 22:03:41]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2015-02-17 22:05:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921023002/210001

[commit-bot: I haz the power, 2015-02-17 22:07:44]

Committed patchset #6 (id:210001)

[commit-bot: I haz the power, 2015-02-17 22:08:18]

Patchset 6 (id:??) landed as
https://crrev.com/c7e7e13f022f30f6b3eefd919881cb57513dca40
Cr-Commit-Position: refs/heads/master@{#316666}