Run gn_unittests on gn_upload step.

Run gn_unittests on gn_upload step.

After the fix in
https://chromium.googlesource.com/chromium/src.git/+/7f1ee75851d2a0f19ce8fe993cd7e9e1ccfebf4e
we should be able to run gn_unittests from anywhere, not just from the
root of the checkout.

BUG=443813
R=dpranke@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294040

[Dirk Pranke, 2015-02-11 17:22:24]

lgtm

[tfarina, 2015-02-12 12:43:08]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-12 12:43:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920493002/1

[commit-bot: I haz the power, 2015-02-12 12:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-12 12:46:41]

Presubmit check for 920493002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
scripts/slave/unittests/recipe_simulation_test.py (32.93s) failed
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F..F..........F........F..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

======================================================================
FAIL:
chromium_gn_upload.full_tryserver_chromium_linux_linux_chromium_gn_upload_x86
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x86.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 93,100 ****
--- 93,116 ----
   {'cmd': ['[SLAVE_BUILD]/src/out/Release/gn', '--version'],
    'name': 'gn version'},
   {'cmd': ['python',
            '-u',
+           '[BUILD]/scripts/slave/runtest.py',
+           '--target',
+           'Release',
+           '--no-xvfb',
+           '--factory-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "linux_chromium_gn_upload_x86", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.linux", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--build-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "linux_chromium_gn_upload_x86", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.linux", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--builder-name=linux_chromium_gn_upload_x86',
+           '--slave-name=TestSlavename',
+           '--build-number=571',
+           'gn_unittests'],
+   'cwd': '[SLAVE_BUILD]/src',
+   'name': 'gn_unittests'},
+  {'cmd': ['python',
+           '-u',
            '[DEPOT_TOOLS]/upload_to_google_storage.py',
            '-b',
            'chromium-gn',
            '[SLAVE_BUILD]/src/out/Release/gn'],

======================================================================
FAIL: chromium_gn_upload.full_tryserver_chromium_mac_mac_chromium_gn_upload
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_mac_mac_chromium_gn_upload.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 93,100 ****
--- 93,115 ----
   {'cmd': ['[SLAVE_BUILD]/src/out/Release/gn', '--version'],
    'name': 'gn version'},
   {'cmd': ['python',
            '-u',
+           '[BUILD]/scripts/slave/runtest.py',
+           '--target',
+           'Release',
+           '--factory-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "mac_chromium_gn_upload", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.mac", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--build-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "mac_chromium_gn_upload", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.mac", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--builder-name=mac_chromium_gn_upload',
+           '--slave-name=TestSlavename',
+           '--build-number=571',
+           'gn_unittests'],
+   'cwd': '[SLAVE_BUILD]/src',
+   'name': 'gn_unittests'},
+  {'cmd': ['python',
+           '-u',
            '[DEPOT_TOOLS]/upload_to_google_storage.py',
            '-b',
            'chromium-gn',
            '[SLAVE_BUILD]/src/out/Release/gn'],

======================================================================
FAIL: chromium_gn_upload.full_tryserver_chromium_win_win8_chromium_gn_upload
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 93,100 ****
--- 93,115 ----
   {'cmd': ['[SLAVE_BUILD]\\src\\out\\Release\\gn.exe', '--version'],
    'name': 'gn version'},
   {'cmd': ['python',
            '-u',
+           '[BUILD]\\scripts\\slave\\runtest.py',
+           '--target',
+           'Release',
+           '--factory-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "win8_chromium_gn_upload", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.win", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--build-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "win8_chromium_gn_upload", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.win", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--builder-name=win8_chromium_gn_upload',
+           '--slave-name=TestSlavename',
+           '--build-number=571',
+           'gn_unittests.exe'],
+   'cwd': '[SLAVE_BUILD]\\src',
+   'name': 'gn_unittests'},
+  {'cmd': ['python',
+           '-u',
            '[DEPOT_TOOLS]\\upload_to_google_storage.py',
            '-b',
            'chromium-gn',
            '[SLAVE_BUILD]\\src\\out\\Release\\gn.exe'],

======================================================================
FAIL:
chromium_gn_upload.full_tryserver_chromium_linux_linux_chromium_gn_upload_x64
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x64.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 93,100 ****
--- 93,116 ----
   {'cmd': ['[SLAVE_BUILD]/src/out/Release/gn', '--version'],
    'name': 'gn version'},
   {'cmd': ['python',
            '-u',
+           '[BUILD]/scripts/slave/runtest.py',
+           '--target',
+           'Release',
+           '--no-xvfb',
+           '--factory-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "linux_chromium_gn_upload_x64", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.linux", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--build-properties',
+           '{"blamelist": ["cool_dev1337@chromium.org", "hax@chromium.org"],
"branch": "", "buildername": "linux_chromium_gn_upload_x64", "buildnumber": 571,
"issue": 12853011, "mastername": "tryserver.chromium.linux", "patch_project":
"chromium", "patchset": 1, "project": "chrome", "recipe": "chromium_gn_upload",
"repository": "", "requester": "commit-bot@chromium.org", "revision": "HEAD",
"rietveld": "https://codereview.chromium.org", "slavename": "TestSlavename",
"workdir": "/path/to/workdir/TestSlavename"}',
+           '--builder-name=linux_chromium_gn_upload_x64',
+           '--slave-name=TestSlavename',
+           '--build-number=571',
+           'gn_unittests'],
+   …
(message too large)

[tfarina, 2015-02-12 13:02:18]

New patchsets have been uploaded after l-g-t-m from dpranke@chromium.org

[tfarina, 2015-02-12 13:02:33]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-12 13:02:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920493002/20001

[commit-bot: I haz the power, 2015-02-12 13:05:46]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294040