scripts/slave/recipes/chromium_gn_upload.py - Issue 920493002: Run gn_unittests on gn_upload step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn_upload.py

Issue 920493002: Run gn_unittests on gn_upload step. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: ./scripts/slave/unittests/recipe_simulation_test.py train Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipes/chromium_gn_upload.py

diff --git a/scripts/slave/recipes/chromium_gn_upload.py b/scripts/slave/recipes/chromium_gn_upload.py

index 5f181e688c9bba8bbde6139cc915201ac50df95f..d7c8d631fe99602bd8dd41731ef329cb6d9b5ae9 100644

--- a/scripts/slave/recipes/chromium_gn_upload.py

+++ b/scripts/slave/recipes/chromium_gn_upload.py

@@ -88,12 +88,7 @@ def GenSteps(api):

api.step('gn version', [path_to_binary, '--version'])

- # TODO: crbug.com/443813 - if gn_unittests is run from any dir other

- # than the checkout root, it'll fail. Unfortunately, if runtest

- # is run from any place other than the checkout root (the directory

- # above api.path['checkout']), it computes the path to the binary

- # incorrectly and fails to find it :(.

- # api.chromium.runtest('gn_unittests', cwd=api.path['checkout'])

+ api.chromium.runtest('gn_unittests', cwd=api.path['checkout'])

api.python('upload',

api.path['depot_tools'].join('upload_to_google_storage.py'),