scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json - Issue 920493002: Run gn_unittests on gn_upload step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

Issue 920493002: Run gn_unittests on gn_upload step. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: ./scripts/slave/unittests/recipe_simulation_test.py train Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_mac_mac_chromium_gn_upload.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

diff --git a/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json b/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

index 8e42ca9bab4f6bed8fb489f2fc912a1198b534d2..3d4f0e12414783f24d570a2ccb0076ca04cfc2f8 100644

--- a/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

+++ b/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

@@ -125,6 +125,25 @@

"cmd": [

"python",

"-u",

+ "[BUILD]\\scripts\\slave\\runtest.py",

+ "--target",

+ "Release",

+ "--factory-properties",

+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"buildername\": \"win8_chromium_gn_upload\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"tryserver.chromium.win\", \"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"chromium_gn_upload\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",

+ "--build-properties",

+ "--builder-name=win8_chromium_gn_upload",

+ "--slave-name=TestSlavename",

+ "--build-number=571",

+ "gn_unittests.exe"

+ ],

+ "cwd": "[SLAVE_BUILD]\\src",

+ "name": "gn_unittests"

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"[DEPOT_TOOLS]\\upload_to_google_storage.py",

"-b",

"chromium-gn",