Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x64.json

Issue 920493002: Run gn_unittests on gn_upload step. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: ./scripts/slave/unittests/recipe_simulation_test.py train Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x64.json
diff --git a/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x64.json b/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x64.json
index 3d6596ff2014d6f4bb87f3a44ad4abf43c5484df..ee8ddde8898a6eb189ccf6248bff1c5c7e29207d 100644
--- a/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x64.json
+++ b/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload_x64.json
@@ -125,6 +125,26 @@
"cmd": [
"python",
"-u",
+ "[BUILD]/scripts/slave/runtest.py",
+ "--target",
+ "Release",
+ "--no-xvfb",
+ "--factory-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"buildername\": \"linux_chromium_gn_upload_x64\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"tryserver.chromium.linux\", \"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"chromium_gn_upload\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--build-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"buildername\": \"linux_chromium_gn_upload_x64\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"tryserver.chromium.linux\", \"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"chromium_gn_upload\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--builder-name=linux_chromium_gn_upload_x64",
+ "--slave-name=TestSlavename",
+ "--build-number=571",
+ "gn_unittests"
+ ],
+ "cwd": "[SLAVE_BUILD]/src",
+ "name": "gn_unittests"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"[DEPOT_TOOLS]/upload_to_google_storage.py",
"-b",
"chromium-gn",

Powered by Google App Engine
This is Rietveld 408576698