Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 22179. If line is empty and selected, remove only trailing spaces after selection. So, Editor will not remove indentation after save. Although later, if nothing is typed on the line, this indentation still will be removed. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22179 Committed: https://code.google.com/p/dart/source/detail?r=43744

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -8 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java	View	5 chunks	+18 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 10 months ago (2015-02-12 22:56:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43744 (presubmit successful).