editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java - Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection.

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java

Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java b/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java

index 0b7fb0aa0bab2d7efeb3ff0fb794d8aef215a5fc..dd8a493fc4198329cc0910b53e7223467f49e732 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java

@@ -23,12 +23,25 @@ public class CodeFormatEditFactoryTest extends TestCase {

static final String EOL = System.getProperty("line.separator");

+ public void test_removeTrailingWhitespace_emptyLine_hasSelection() throws Exception {

+ String original = "main() {" + EOL + " " + EOL + "}";

+ IDocument doc = new Document(original);

+ int selectionStart = ("main() {" + EOL + " ").length();

+ MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(

+ doc,

+ selectionStart,

+ selectionStart);

+ edit.apply(doc);

+ String expected = "main() {" + EOL + " " + EOL + "}";

+ assertEquals(expected, doc.get());

+ }

public void test_removeTrailingWhitespace_none() throws Exception {

String original = "class NoTrailingWhitespace {" + EOL //

+ " void foo() { }" + EOL //

+ "}";

IDocument doc = new Document(original);

- MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc);

+ MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc, -1, 0);

assertEquals(0, edit.getChildrenSize());

edit.apply(doc);

assertEquals(original, doc.get());

@@ -39,7 +52,7 @@ public class CodeFormatEditFactoryTest extends TestCase {

+ " void foo() { }" + EOL //

+ "}" + EOL;

IDocument doc = new Document(original);

- MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc);

+ MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc, -1, 0);

assertEquals(0, edit.getChildrenSize());

edit.apply(doc);

assertEquals(original, doc.get());

@@ -50,7 +63,7 @@ public class CodeFormatEditFactoryTest extends TestCase {

+ " void foo() { }" + EOL //

+ "}\r";

IDocument doc = new Document(original);

- MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc);

+ MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc, -1, 0);

assertEquals(0, edit.getChildrenSize());

edit.apply(doc);

assertEquals(original, doc.get());

@@ -61,7 +74,7 @@ public class CodeFormatEditFactoryTest extends TestCase {

+ " void foo() { }" + EOL //

+ "}\n";

IDocument doc = new Document(original);

- MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc);

+ MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc, -1, 0);

assertEquals(0, edit.getChildrenSize());

edit.apply(doc);

assertEquals(original, doc.get());

@@ -73,7 +86,7 @@ public class CodeFormatEditFactoryTest extends TestCase {

+ "} " + EOL //

+ " " + EOL;

IDocument doc = new Document(original);

- MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc);

+ MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(doc, -1, 0);

assertEquals(3, edit.getChildrenSize());

edit.apply(doc);

String expected = "class NoTrailingWhitespace {" + EOL //