editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java - Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java

Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java

index 26776c69a5a15cbd222d591e3993bd291f4e3822..facfc4682f6f3c75dc2633283bb4dc8e2811bafc 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java

@@ -49,7 +49,8 @@ public class CodeFormatEditFactory {

* @return an edit that removes all trailing whitespace

* @throws CoreException if an error occurs in creating the edit

- public static MultiTextEdit removeTrailingWhitespace(IDocument document) throws CoreException {

+ public static MultiTextEdit removeTrailingWhitespace(IDocument document, int selectionStart,

+ int selectionEnd) throws CoreException {

MultiTextEdit textEdit = new MultiTextEdit();

@@ -79,8 +80,13 @@ public class CodeFormatEditFactory {

lineStart,

lineExclusiveEnd - 1,

document);

j++;

+ if (selectionStart != -1 && j == lineStart && selectionStart > lineStart

+ && selectionEnd <= lineExclusiveEnd) {

+ j = selectionStart;

+ }

if (j < lineExclusiveEnd) {

DeleteEdit edit = new DeleteEdit(j, lineExclusiveEnd - j);

textEdit.addChild(edit);