editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java - Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java

Issue 920073003: Issue 22179. If line is empty and selected, remove only trailing spaces after selection. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactory.java ('k') | editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/editor/saveactions/CodeFormatEditFactoryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java

index 3376b429345543859ed2a346b9ebdc238f4eff19..c9fcc27bda8700f5e84b98dde470fc16e4c63e93 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/saveactions/RemoveTrailingWhitespaceAction.java

@@ -18,6 +18,7 @@ import org.eclipse.jface.text.DocumentRewriteSessionType;

import org.eclipse.jface.text.IDocument;

import org.eclipse.jface.text.IDocumentExtension4;

import org.eclipse.jface.text.source.ISourceViewer;

+import org.eclipse.swt.graphics.Point;

import org.eclipse.text.edits.MultiTextEdit;

import org.eclipse.text.edits.TextEdit;

@@ -64,7 +65,13 @@ public class RemoveTrailingWhitespaceAction {

}

try {

- MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(document);

+ Point selectionRange = viewer.getSelectedRange();

+ int selectionStart = selectionRange.x;

+ int selectionEnd = selectionStart + selectionRange.y;

+ MultiTextEdit edit = CodeFormatEditFactory.removeTrailingWhitespace(

+ document,

+ selectionStart,

+ selectionEnd);

if (edit.hasChildren()) {

applyTextEdit(document, edit);

// using rewrite session causes horizontal scroll bar reset, so we need to show selection